Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maximum call stack size exceeded (RangeError) #12526

Closed
BarryDrez opened this issue May 12, 2023 · 13 comments
Closed

Maximum call stack size exceeded (RangeError) #12526

BarryDrez opened this issue May 12, 2023 · 13 comments

Comments

@BarryDrez
Copy link

Bug Description:

Seeing many errors in the browser console:
rpc-message-encoder.ts:151 Uncaught (in promise) Error: Error during encoding: 'Maximum call stack size exceeded'
at MsgPackMessageEncoder.encode (rpc-message-encoder.ts:151:23)
at MsgPackMessageEncoder.request (rpc-message-encoder.ts:137:14)
at RpcProtocol.sendRequest (rpc-protocol.ts:161:22)
at proxy-handler.ts:74:45

The message appears over and over when selecting different lines in the editor and when scrolling.

Steps to Reproduce:

  1. Clone the repository here: https://github.com/BarryDrez/java-service-editor.git
  2. Build the project
  3. Run the project and look at the browser logs

image

image

Additional Information

  • Operating System: Windows and Linux (in docker container)
  • Theia Version: 1.37
@BarryDrez BarryDrez changed the title Maximum call stack size exceeded Maximum call stack size exceeded (RangeError) May 12, 2023
@vince-fugnitto
Copy link
Member

@BarryDrez can you confirm what version you're using of msgpackr? (ex: yarn why msgpackr) You may be experiencing #12499.

@BarryDrez
Copy link
Author

Hi @vince-fugnitto , thanks for the reply. I do not specify this anywhere. In my node modules, II see the following:
node_modules@theia\core\package.json has "msgpackr": "^1.6.1",

@vince-fugnitto
Copy link
Member

vince-fugnitto commented May 12, 2023

Hi @vince-fugnitto , thanks for the reply. I do not specify this anywhere. In my node modules, II see the following: node_modules@theia\core\package.json has "msgpackr": "^1.6.1",

Can you check which version msgpackr is directly in your node_modules? It should be one of the dependencies you see (ex: node_modules/msgpackr/package.json)

@BarryDrez
Copy link
Author

@vince-fugnitto It is Version 1.9.1

@vince-fugnitto
Copy link
Member

It seems that you're running into #12499 then, thanks for confirming 👍 Until it is fixed you can add a yarn resolution to pin the dependency to the version we use in this repo (1.8.3):

theia/yarn.lock

Lines 7571 to 7576 in 23e3df5

msgpackr@^1.6.1:
version "1.8.3"
resolved "https://registry.yarnpkg.com/msgpackr/-/msgpackr-1.8.3.tgz#78c1b91359f72707f4abeaca40cc423bd2d75185"
integrity sha512-m2JefwcKNzoHYXkH/5jzHRxAw7XLWsAdvu0FOJ+OLwwozwOV/J6UA62iLkfIMbg7G8+dIuRwgg6oz+QoQ4YkoA==
optionalDependencies:
msgpackr-extract "^3.0.0"

@BarryDrez
Copy link
Author

Thanks a lot. I will try that.

@vince-fugnitto
Copy link
Member

Closing in favor of #12499.
I updated the migration documentation to add a note for the resolution as well 8194a49.

@vince-fugnitto vince-fugnitto closed this as not planned Won't fix, can't repro, duplicate, stale May 15, 2023
@BarryDrez
Copy link
Author

@vince-fugnitto Just wanted to let you know that this solved the problem.

@BarryDrez
Copy link
Author

@vince-fugnitto Ever since I made this change, the language server is taking a very long time to load. Cleaning doesn't seem to help. Is this related to the resolution?

@vince-fugnitto
Copy link
Member

@vince-fugnitto Ever since I made this change, the language server is taking a very long time to load. Cleaning doesn't seem to help. Is this related to the resolution?

@BarryDrez I don't think so, the resolution uses the version we use in this repository already. For which language are you noticing it take time?

@BarryDrez
Copy link
Author

@vince-fugnitto I am noticing this for Java.

@BarryDrez
Copy link
Author

Here is a list of all of my plugins:

  "theiaPlugins": {
    "vscode.markdown-language-features": "https://open-vsx.org/api/vscode/markdown-language-features/1.70.2/file/vscode.markdown-language-features-1.70.2.vsix",
    "vscode-builtin-extensions-pack": "https://open-vsx.org/api/eclipse-theia/builtin-extension-pack/1.70.2/file/eclipse-theia.builtin-extension-pack-1.70.2.vsix",
    "redhat.java": "https://open-vsx.org/api/redhat/java/1.19.2023052304/file/redhat.java-1.19.2023052304.vsix",
    "vscjava.vscode-java-debug": "https://open-vsx.org/api/vscjava/vscode-java-debug/0.50.0/file/vscjava.vscode-java-debug-0.50.0.vsix",
    "vscjava.vscode-java-dependency": "https://open-vsx.org/api/vscjava/vscode-java-dependency/0.25.11/file/vscjava.vscode-java-dependency-0.25.11.vsix"
  },

@BarryDrez
Copy link
Author

I tried some earlier versions of the plugins, and now it is starting up faster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants