Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode: add support for contributes.icons contribution point #12355

Closed
Tracked by #13192
tsmaeder opened this issue Mar 27, 2023 · 1 comment · Fixed by #12912
Closed
Tracked by #13192

vscode: add support for contributes.icons contribution point #12355

tsmaeder opened this issue Mar 27, 2023 · 1 comment · Fixed by #12912
Labels
contribution-point issues related to vscode contribution point support extension system issues related to the extension system vscode issues related to VSCode compatibility

Comments

@tsmaeder
Copy link
Contributor

Bug Description:

Some of the editor toolbar icons are now visible when installing gitlens

Steps to Reproduce:

  1. Install gitlens
  2. Open a typescript editor
  3. Observe: on the right side of the editor tab-bar, there is a toolbar, but some of the icons from the gitlens extension are invisible, even though room is allocated for the icons

Additional Information

  • Operating System: WIndows
  • Theia Version: master
@tsmaeder tsmaeder added extension system issues related to the extension system editor issues related to the editor labels Mar 27, 2023
@vince-fugnitto
Copy link
Member

@tsmaeder I don't believe we support the icons contribution point yet which gitlens uses to contribute it's icons:

@vince-fugnitto vince-fugnitto changed the title Gitlens toolbar icons don't show vscode: add support for contributes.icons contribution point Jul 24, 2023
@vince-fugnitto vince-fugnitto added vscode issues related to VSCode compatibility contribution-point issues related to vscode contribution point support and removed editor issues related to the editor labels Jul 24, 2023
@JonasHelming JonasHelming mentioned this issue Dec 19, 2023
66 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution-point issues related to vscode contribution point support extension system issues related to the extension system vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants