Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

menu: empty submenus are still rendered #11567

Closed
vince-fugnitto opened this issue Aug 12, 2022 · 0 comments · Fixed by #11577
Closed

menu: empty submenus are still rendered #11567

vince-fugnitto opened this issue Aug 12, 2022 · 0 comments · Fixed by #11577
Assignees
@colin-grant-work
Labels
menus issues related to the menu

Comments

@vince-fugnitto
Copy link
Member

Bug Description:

There is a regression following #11290 (confirmed with a git bisect) where empty submenus are still rendered in the application. The bug seems to happen when actions are in fact registered to the submenu but they have isVisible set to false.

image

Steps to Reproduce:

  1. I pushed a commit which highlights the problem (131c0da)
  2. start the application
  3. confirm that the bug exists in the Edit menu as Test is rendered but has no items

Originally reported in #11566
@vince-fugnitto vince-fugnitto added the menus issues related to the menu label Aug 12, 2022
@colin-grant-work colin-grant-work self-assigned this Aug 16, 2022
@colin-grant-work colin-grant-work mentioned this issue Aug 16, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@colin-grant-work colin-grant-work

Labels
menus issues related to the menu
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix empty menus in browser colin-grant-work/theia
2 participants
@vince-fugnitto @colin-grant-work