Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolveDebugConfiguration returning 'undefined' or 'null' does not comply to vscode API #10998

Closed
alvsan09 opened this issue Apr 6, 2022 · 0 comments · Fixed by #10999
Closed
Assignees
Labels
debug issues that related to debug functionality vscode issues related to VSCode compatibility

Comments

@alvsan09
Copy link
Contributor

alvsan09 commented Apr 6, 2022

Bug Description:

The vscode plugin ms-vscode.js-debug provides a dynamic configuration called Create Java Debug Terminal
which does not actually require a session, it simply opens a terminal as a side effect of starting it, and when the extension
provider is called with resolveDebugConfiguration the extension simply returns undefined to indicate that no further processing is required.

This is expected as specified: https://code.visualstudio.com/api/references/vscode-api#DebugConfigurationProvider

Theia currently ignores undefined or null, and starts the session using the configuration in place before an undefined or null is returned.

Steps to Reproduce:

As it can be seen in the gif below this case starts a session with a corresponding terminal in addition to the terminal triggered by the extension.

  1. Open the command palette and type debug , not the ending space is important
  2. Select Create JavaScript Debug terminal from the list of available configurations
  3. See that a Session and corresponding terminal is started in addition to a JavaScript Debug Terminal

js-debug-two-terminals

Additional Information

  • Operating System: Ubuntu
  • Theia Version: 1.24.0
@alvsan09 alvsan09 added vscode issues related to VSCode compatibility debug issues that related to debug functionality labels Apr 6, 2022
@alvsan09 alvsan09 self-assigned this Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debug issues that related to debug functionality vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant