Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Build Tools now included with NodeJS installer #10856

Closed
hoangphamEclipse opened this issue Mar 7, 2022 · 2 comments · Fixed by #10862
Closed

Windows Build Tools now included with NodeJS installer #10856

hoangphamEclipse opened this issue Mar 7, 2022 · 2 comments · Fixed by #10862
Labels
documentation issues related to documentation OS/Windows issues related to the Windows OS

Comments

@hoangphamEclipse
Copy link
Contributor

Bug Description:

I was trying to build Theia on my local machine following these instructions. The installation for Windows Build Tools freezes after Python is installed. Below is the console log up until the installation freezes:

npm --add-python-to-path install --global --production windows-build-tools
npm WARN deprecated windows-build-tools@5.2.2: Node.js now includes build tools for Windows. You probably no longer need this tool. See https://github.com/felixrieseberg/windows-build-tools for details.
npm WARN deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated har-validator@5.1.5: this library is no longer supported
npm WARN deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.

> windows-build-tools@5.2.2 postinstall C:\Users\HoangPham\scoop\apps\nvm\current\nodejs\nodejs\node_modules\windows-build-tools
> node ./dist/index.js



Downloading python-2.7.15.amd64.msi
[>                                            ] 0.0% (0 B/s)
Downloaded python-2.7.15.amd64.msi. Saved to C:\Users\HoangPham\.windows-build-tools\python-2.7.15.amd64.msi.
Downloading vs_BuildTools.exe
[>                                            ] 0.0% (0 B/s)
Downloaded vs_BuildTools.exe. Saved to C:\Users\HoangPham\.windows-build-tools\vs_BuildTools.exe.

Starting installation...
Launched installers, now waiting for them to finish.
This will likely take some time - please be patient!

Status from the installers:
---------- Visual Studio Build Tools ----------
Still waiting for installer log file...
------------------- Python --------------------
Successfully installed Python 2.7

When trying to solve this issue, I found that Windows Build Tools is now included with NodeJS installer and the npm package is now deprecated. See the deprecation message here. Thus, it is not necessary to install Windows Build Tools manually anymore because the NodeJS installer can automatically install the required tools.

Therefore, the instructions for building Theia on Windows should be updated to reflect this change.

Steps to Reproduce:

  1. Follow the instructions here up until and including installing yarn.
  2. Run the provided command to install npm.

Additional Information

  • Operating System: Windows 10
@vince-fugnitto vince-fugnitto added documentation issues related to documentation OS/Windows issues related to the Windows OS labels Mar 7, 2022
@vince-fugnitto
Copy link
Member

@hoangphamEclipse thank you for the detailed issue, are you interested in contributing a pull-request to update the documentation?

@hoangphamEclipse
Copy link
Contributor Author

Sure I can do that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation issues related to documentation OS/Windows issues related to the Windows OS
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants