From a6fb8829705796ee43cf05aa220a61137e01c369 Mon Sep 17 00:00:00 2001 From: Jonah Iden Date: Tue, 4 Jun 2024 16:19:01 +0200 Subject: [PATCH] fix editors theme change and widget not attached error (#13757) Signed-off-by: Jonah Iden --- packages/monaco/src/browser/monaco-standalone-theme-service.ts | 1 + .../src/main/browser/notebooks/renderers/cell-output-webview.tsx | 1 + 2 files changed, 2 insertions(+) diff --git a/packages/monaco/src/browser/monaco-standalone-theme-service.ts b/packages/monaco/src/browser/monaco-standalone-theme-service.ts index f36d7083d6b48..cae2bffd3f3c7 100644 --- a/packages/monaco/src/browser/monaco-standalone-theme-service.ts +++ b/packages/monaco/src/browser/monaco-standalone-theme-service.ts @@ -41,6 +41,7 @@ export class MonacoStandaloneThemeService extends StandaloneThemeService { for (let i = 0; i < this.styleElements.length; i++) { if (this.styleElements[i] === style) { this.styleElements.splice(i, 1); + style.remove(); return; } } diff --git a/packages/plugin-ext/src/main/browser/notebooks/renderers/cell-output-webview.tsx b/packages/plugin-ext/src/main/browser/notebooks/renderers/cell-output-webview.tsx index efd1845c92e6f..98cac69ef734c 100644 --- a/packages/plugin-ext/src/main/browser/notebooks/renderers/cell-output-webview.tsx +++ b/packages/plugin-ext/src/main/browser/notebooks/renderers/cell-output-webview.tsx @@ -187,6 +187,7 @@ export class CellOutputWebviewImpl implements CellOutputWebview, Disposable { } this.webviewWidget = await this.widgetManager.getOrCreateWidget(WebviewWidget.FACTORY_ID, { id: this.id }); + this.webviewWidget.parent = this.editor ?? null; this.webviewWidget.setContentOptions({ allowScripts: true, // eslint-disable-next-line max-len