Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StringIndexOutOfBoundsException when CMakeListst.txt is missing #66

Closed
15knots opened this issue Sep 6, 2022 · 3 comments
Closed

StringIndexOutOfBoundsException when CMakeListst.txt is missing #66

15knots opened this issue Sep 6, 2022 · 3 comments
Assignees
Milestone

Comments

@15knots
Copy link
Contributor

15knots commented Sep 6, 2022

CDT cmake core build fails to parse the error.

java.lang.StringIndexOutOfBoundsException: String index out of range: -11
at java.base/java.lang.String.substring(String.java:1841)
at org.eclipse.cdt.cmake.core.internal.CMakeErrorParser$MessageHandler.processMessage(CMakeErrorParser.java:203)
at org.eclipse.cdt.cmake.core.internal.CMakeErrorParser.processMessage(CMakeErrorParser.java:126)
at org.eclipse.cdt.cmake.core.internal.CMakeErrorParser.close(CMakeErrorParser.java:96)

This should produce an error in the problems view instead.

@15knots 15knots self-assigned this Sep 6, 2022
@jonahgraham
Copy link
Member

Thanks @15knots - BTW as part of the transition to GitHub where issues and PRs are quite similar we removed requirement to have issues, instead only recommending them for larger changes.

Do you think this warrants a 10.7.x release (i.e. backport this change). Or should we wait until next release in Dec?

@jonahgraham jonahgraham added this to the 11.0.0 milestone Sep 7, 2022
@15knots
Copy link
Contributor Author

15knots commented Sep 7, 2022 via email

@jonahgraham
Copy link
Member

BTW: Would it be possible to make the cmake error parser public API? Its code is almost 1:1 ported from my MBS plugin and I would like to have only a single point where to do bug fixes. /Martin

This got answered in another thread on cdt-dev - please let me know if there is more I can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants