Skip to content
This repository has been archived by the owner on May 7, 2020. It is now read-only.

[Paper UI] Sliders for Dimmer items have lost % sign #3518

Closed
kaikreuzer opened this issue May 25, 2017 · 2 comments · Fixed by #3525
Closed

[Paper UI] Sliders for Dimmer items have lost % sign #3518

kaikreuzer opened this issue May 25, 2017 · 2 comments · Fixed by #3525

Comments

@kaikreuzer
Copy link
Contributor

So far, the Paper UI showed the textual percent value for sliders. This does not seem to be the case anymore:

screen shot 2017-05-25 at 16 18 00

@aounhaider1 & @htreu Any idea what might have caused this change?

@aounhaider1
Copy link
Contributor

It is caused by #3466 which solved #3455. I intentionally removed the manual formatting done in PaperUI. Now it only formats it according to the given pattern. But I think to accommodate what you said, we can check if the pattern is empty and can do manual formatting in that case. Wdyt?

@kaikreuzer
Copy link
Contributor Author

We only render the slider for Dimmer items which are by definition always % values - so yes, I would say if there is no formatting pattern, the % should always be displayed as the default.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants