Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geom_violinhalf: add draw_quantiles? #68

Open
MatthieuStigler opened this issue Apr 30, 2020 · 3 comments
Open

geom_violinhalf: add draw_quantiles? #68

MatthieuStigler opened this issue Apr 30, 2020 · 3 comments
Assignees
Labels
Enhancement 💥 New feature or request

Comments

@MatthieuStigler
Copy link

Describe the solution you'd like
It would be great if argument draw_quantiles that is found in geom_violin could be also implemented for geom_violinhalf!

Thanks :-)

@strengejacke
Copy link
Member

@DominiqueMakowski what do you say? I think you have implemented this function in see.

@DominiqueMakowski
Copy link
Member

I don't think it's easy to add given the current implemention, tho to be honest we should probably rely on tidybayes for violinhalf, as it's better implemented there with a lot of possibilities (http://mjskay.github.io/tidybayes/articles/slabinterval.html)

@IndrajeetPatil
Copy link
Member

http://mjskay.github.io/tidybayes/articles/slabinterval.html is 404.

But, I agree, we shouldn't be reinventing the wheel here if there is already a good visualization package out there that does exactly the same thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement 💥 New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants