From 5a232c8c1c6391a66a295539af4c3c34e0f879b3 Mon Sep 17 00:00:00 2001 From: ketaki-deodhar <116035339+ketaki-deodhar@users.noreply.github.com> Date: Thu, 28 Nov 2024 11:52:19 -0800 Subject: [PATCH] 20619 (#3099) * 20619 - update allowable actions * 20619 - fix unit test * 20619 - fix unit test * 20619 - fix unit test --- legal-api/src/legal_api/services/authz.py | 8 +++-- .../tests/unit/services/test_authorization.py | 35 +++++++++---------- 2 files changed, 22 insertions(+), 21 deletions(-) diff --git a/legal-api/src/legal_api/services/authz.py b/legal-api/src/legal_api/services/authz.py index ac17bb254f..087236e898 100644 --- a/legal-api/src/legal_api/services/authz.py +++ b/legal-api/src/legal_api/services/authz.py @@ -263,7 +263,6 @@ def get_allowable_filings_dict(): 'blockerChecks': { 'warningTypes': [WarningType.MISSING_REQUIRED_BUSINESS_INFO], 'business': [BusinessBlocker.DEFAULT, - BusinessBlocker.NOT_IN_GOOD_STANDING, BusinessBlocker.IN_DISSOLUTION] } }, @@ -373,7 +372,9 @@ def get_allowable_filings_dict(): 'alteration': { 'legalTypes': ['BC', 'BEN', 'ULC', 'CC', 'C', 'CBEN', 'CUL', 'CCC'], 'blockerChecks': { - 'business': [BusinessBlocker.DEFAULT, BusinessBlocker.IN_DISSOLUTION], + 'business': [BusinessBlocker.DEFAULT, + BusinessBlocker.NOT_IN_GOOD_STANDING, + BusinessBlocker.IN_DISSOLUTION], 'invalidStateFilings': ['restoration.limitedRestoration', 'restoration.limitedRestorationExtension'] } @@ -471,7 +472,8 @@ def get_allowable_filings_dict(): 'specialResolution': { 'legalTypes': ['CP'], 'blockerChecks': { - 'business': [BusinessBlocker.DEFAULT] + 'business': [BusinessBlocker.DEFAULT, + BusinessBlocker.NOT_IN_GOOD_STANDING] } }, 'transition': { diff --git a/legal-api/tests/unit/services/test_authorization.py b/legal-api/tests/unit/services/test_authorization.py index 20a4df2789..5a33d92603 100644 --- a/legal-api/tests/unit/services/test_authorization.py +++ b/legal-api/tests/unit/services/test_authorization.py @@ -1535,6 +1535,7 @@ def mock_auth(one, two): # pylint: disable=unused-argument; mocks of library me FilingKey.COD_CP, FilingKey.CORRCTN, FilingKey.COURT_ORDER, + FilingKey.VOL_DISS, FilingKey.ADM_DISS, FilingKey.REGISTRARS_NOTATION, FilingKey.REGISTRARS_ORDER, @@ -1547,6 +1548,7 @@ def mock_auth(one, two): # pylint: disable=unused-argument; mocks of library me FilingKey.COD_CORPS, FilingKey.CORRCTN, FilingKey.COURT_ORDER, + FilingKey.VOL_DISS, FilingKey.ADM_DISS, FilingKey.REGISTRARS_NOTATION, FilingKey.REGISTRARS_ORDER, @@ -1560,6 +1562,7 @@ def mock_auth(one, two): # pylint: disable=unused-argument; mocks of library me FilingKey.COD_CORPS, FilingKey.CORRCTN, FilingKey.COURT_ORDER, + FilingKey.VOL_DISS, FilingKey.ADM_DISS, FilingKey.REGISTRARS_NOTATION, FilingKey.REGISTRARS_ORDER, @@ -1571,6 +1574,7 @@ def mock_auth(one, two): # pylint: disable=unused-argument; mocks of library me FilingKey.CONV_FIRMS, FilingKey.CORRCTN_FIRMS, FilingKey.COURT_ORDER, + FilingKey.VOL_DISS_FIRMS, FilingKey.ADM_DISS_FIRMS, FilingKey.REGISTRARS_NOTATION, FilingKey.REGISTRARS_ORDER])), @@ -1579,18 +1583,15 @@ def mock_auth(one, two): # pylint: disable=unused-argument; mocks of library me ('general_user_cp', True, Business.State.ACTIVE, ['CP'], 'general', [BASIC_USER], expected_lookup([FilingKey.AR_CP, FilingKey.COA_CP, - FilingKey.COD_CP, - FilingKey.SPECIAL_RESOLUTION])), + FilingKey.COD_CP])), ('general_user_corps', True, Business.State.ACTIVE, ['BC', 'BEN', 'CC', 'ULC'], 'general', [BASIC_USER], - expected_lookup([FilingKey.ALTERATION, - FilingKey.AR_CORPS, + expected_lookup([FilingKey.AR_CORPS, FilingKey.COA_CORPS, FilingKey.COD_CORPS, FilingKey.TRANSITION])), ('general_user_continue_in_corps', True, Business.State.ACTIVE, ['C', 'CBEN', 'CCC', 'CUL'], 'general', [BASIC_USER], - expected_lookup([FilingKey.ALTERATION, - FilingKey.AR_CORPS, + expected_lookup([FilingKey.AR_CORPS, FilingKey.COA_CORPS, FilingKey.COD_CORPS, FilingKey.TRANSITION])), @@ -2635,8 +2636,7 @@ def mock_auth(one, two): # pylint: disable=unused-argument; mocks of library me ('general_user_cp', True, Business.State.ACTIVE, ['CP'], 'general', [BASIC_USER], expected_lookup([FilingKey.AR_CP, FilingKey.COA_CP, - FilingKey.COD_CP, - FilingKey.SPECIAL_RESOLUTION])), + FilingKey.COD_CP])), ('general_user_corps', True, Business.State.ACTIVE, ['BC', 'BEN', 'CC', 'ULC'], 'general', [BASIC_USER], expected_lookup([FilingKey.AR_CORPS, FilingKey.COA_CORPS, @@ -2709,6 +2709,7 @@ def mock_auth(one, two): # pylint: disable=unused-argument; mocks of library me FilingKey.COD_CP, FilingKey.CORRCTN, FilingKey.COURT_ORDER, + FilingKey.VOL_DISS, FilingKey.ADM_DISS, FilingKey.REGISTRARS_NOTATION, FilingKey.REGISTRARS_ORDER, @@ -2722,6 +2723,7 @@ def mock_auth(one, two): # pylint: disable=unused-argument; mocks of library me FilingKey.COD_CORPS, FilingKey.CORRCTN, FilingKey.COURT_ORDER, + FilingKey.VOL_DISS, FilingKey.ADM_DISS, FilingKey.REGISTRARS_NOTATION, FilingKey.REGISTRARS_ORDER, @@ -2763,6 +2765,7 @@ def mock_auth(one, two): # pylint: disable=unused-argument; mocks of library me FilingKey.COD_CORPS, FilingKey.CORRCTN, FilingKey.COURT_ORDER, + FilingKey.VOL_DISS, FilingKey.ADM_DISS, FilingKey.REGISTRARS_NOTATION, FilingKey.REGISTRARS_ORDER, @@ -2783,19 +2786,15 @@ def mock_auth(one, two): # pylint: disable=unused-argument; mocks of library me ('general_user_cp', Business.State.ACTIVE, ['CP'], 'general', [BASIC_USER], None, expected_lookup([FilingKey.AR_CP, FilingKey.COA_CP, - FilingKey.COD_CP, - FilingKey.SPECIAL_RESOLUTION])), + FilingKey.COD_CP])), ('general_user_corps', Business.State.ACTIVE, ['BC', 'BEN', 'CC', 'ULC'], 'general', [BASIC_USER], None, - expected_lookup([ - FilingKey.ALTERATION, - FilingKey.AR_CORPS, - FilingKey.COA_CORPS, - FilingKey.COD_CORPS, - FilingKey.TRANSITION])), + expected_lookup([FilingKey.AR_CORPS, + FilingKey.COA_CORPS, + FilingKey.COD_CORPS, + FilingKey.TRANSITION])), ('general_user_continue_in_corps', Business.State.ACTIVE, ['C', 'CBEN', 'CCC', 'CUL'], 'general', [BASIC_USER], None, - expected_lookup([FilingKey.ALTERATION, - FilingKey.AR_CORPS, + expected_lookup([FilingKey.AR_CORPS, FilingKey.COA_CORPS, FilingKey.COD_CORPS, FilingKey.TRANSITION])),