Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More systematic compiler flags for CI; separate Conda-style builds #360
More systematic compiler flags for CI; separate Conda-style builds #360
Changes from 17 commits
aeab922
052a41d
8644c0a
6bd5916
c83d91b
63d5a78
25c8c88
4158730
8fe45da
ac2bca0
30bc8d6
f57a7bc
8122116
1cc2ab8
214815e
074471e
810ca90
c702806
dba1823
7198a79
8136091
e04068b
2646bf5
adb8844
82b3ef5
531c63f
ecb0f84
fb48778
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We test
RelWithDebugInfo
with no extra flags inconda-style-builds.yml
. Instead ofDebug
with extra flags andRelWithDebugInfo
without extra flags, I would test onlyRelWithDebugInfo
with extra flags in this workflow.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor(?) difference is that
continuous-integration
uses the systemgfortran
whileconda-style-builds
uses theconda
-installedgfortran
.I was thinking of
continuous-integration
as a way to run the code with maximum debugging, which motivatedDebug
builds with extra flags. @skosukhin Do you think we'll be able to isolate any errors introduced withRelWithDebugInfo
?