-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More systematic compiler flags for CI; separate Conda-style builds #360
Merged
+112
−109
Merged
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
aeab922
Conda-compatible CI
RobertPincus 052a41d
Don't specify compiler version
RobertPincus 8644c0a
Consolidate conda installs, remove standards flag
RobertPincus 6bd5916
Multi-line syntax
RobertPincus c83d91b
Test many gfortran variants only on Linux
RobertPincus 63d5a78
FFLAGS -> CMAKE_Fortran_FLAGS
RobertPincus 25c8c88
Specify FFLAGS to CMake, not via environment
RobertPincus 4158730
Don't keep running conda builds; different debug glaf approach
RobertPincus 8fe45da
Quotes?
RobertPincus ac2bca0
Spaces????
RobertPincus 30bc8d6
Or no quotes
RobertPincus f57a7bc
Well phew... Need to specify FFLAGS to CMake?
RobertPincus 8122116
Remove action running on branch
RobertPincus 1cc2ab8
Why is pre-commit failing in Actions but not locally?
RobertPincus 214815e
Update .github/workflows/conda-style-builds.yml
RobertPincus 074471e
Re-enable Lumi CI (#355)
RobertPincus 810ca90
Revert - forgot that Lumi CI is out of date
RobertPincus c702806
Change handling of Fortran compilation flags (needed only for debugging)
RobertPincus dba1823
Syntax
RobertPincus 7198a79
Syntax?
RobertPincus 8136091
Refining conda-style builds
RobertPincus e04068b
What about Release builds?
RobertPincus 2646bf5
Remove Release build - failing on Linux
RobertPincus adb8844
Update action (#362)
RobertPincus 82b3ef5
Removed unused compile definitions (#361)
makepath-alex 531c63f
Suggestions from @skosukhin
RobertPincus ecb0f84
Use system ninja, netcdf
RobertPincus fb48778
ci: simplify
skosukhin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,84 @@ | ||
name: Conda-compatible builds | ||
|
||
on: | ||
push: | ||
branches: | ||
- main | ||
pull_request: | ||
workflow_dispatch: | ||
|
||
defaults: | ||
run: | ||
# Enable Conda environment by using the login shell: | ||
shell: bash -leo pipefail {0} | ||
|
||
jobs: | ||
CI: | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
os: [ubuntu-24.04, macos-13, macos-latest, windows-2022] | ||
build-type: [RelWithDebugInfo] | ||
env: | ||
FC: gfortran | ||
CMAKE_BUILD_PARALLEL_LEVEL: 8 | ||
VERBOSE: | ||
CTEST_PARALLEL_LEVEL: 8 | ||
CTEST_OUTPUT_ON_FAILURE: 1 | ||
runs-on: ${{ matrix.os }} | ||
steps: | ||
# | ||
# Check out repository under $GITHUB_WORKSPACE | ||
# | ||
- name: Check out code | ||
uses: actions/checkout@v4 | ||
# | ||
# Cache Conda packages | ||
# | ||
- name: Cache Conda packages | ||
uses: actions/cache@v4 | ||
with: | ||
path: ~/conda_pkgs_dir | ||
key: conda-pkgs-${{ matrix.os }} | ||
# | ||
# Set up Conda | ||
# | ||
- name: Set up Conda (testing scripts only) | ||
uses: conda-incubator/setup-miniconda@v3 | ||
with: | ||
miniforge-version: latest | ||
activate-environment: rte_rrtmgp_test | ||
environment-file: environment-noplots.yml | ||
python-version: 3.11 | ||
auto-activate-base: false | ||
conda-remove-defaults: true | ||
# Use the cache properly: | ||
use-only-tar-bz2: false | ||
# | ||
# Install compiler and dependencies | ||
# | ||
- name: Install compiler, dependencies | ||
run: | | ||
conda install -c conda-forge "${FC}" netcdf-fortran ninja -y | ||
# | ||
# Adjust toolchain | ||
# | ||
- name: Adjust Windows toolchain | ||
if: matrix.os == 'windows-2022' | ||
run: echo "FC=${FC}.exe" >> "$GITHUB_ENV" | ||
# | ||
# Build libraries, examples, and tests | ||
# | ||
- name: Build libraries and tests | ||
run: | | ||
cmake -S . -B build -G "Ninja" \ | ||
-DCMAKE_BUILD_TYPE=${{ matrix.build-type}} \ | ||
-DRTE_ENABLE_SP=OFF \ | ||
-DBUILD_TESTING=ON | ||
RobertPincus marked this conversation as resolved.
Show resolved
Hide resolved
|
||
cmake --build build | ||
# | ||
# Run examples, tests and checks | ||
# | ||
- name: Run examples, tests and checks | ||
working-directory: build | ||
run: ctest |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there is only one value for the
build-type
in the matrix now, should we remove it and have the following here?