-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend pre-commit configuration #339
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
270e165
to
3744aef
Compare
@skosukhin This seems a good set of automation. We've discussed linting/formatting the Fortran code too but there's no strong consensus on how to do this; I'd be inclined to leave it for now. |
Merged
3744aef
to
b79ef90
Compare
1600406
to
f2897de
Compare
f2897de
to
f44db57
Compare
RobertPincus
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for this @skosukhin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
pre-commit
configuration:isort
,black
andpyproject-flake8
for Python code (all three tools are configured viapyproject.toml
);check-yaml
foryaml
files;actionlint
for GitHub workflows;end-of-file-fixer
andtrailing-whitespace
for alltext
files in the repo;ci
entry with the configuration forpre-commit ci
;.git-blame-ignore-revs
with the changes from Format entire codebase #337;flake8
andactionlint
.Depends on #337.