Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend pre-commit configuration #339

Merged
merged 14 commits into from
Jan 14, 2025
Merged

Extend pre-commit configuration #339

merged 14 commits into from
Jan 14, 2025

Conversation

skosukhin
Copy link
Collaborator

@skosukhin skosukhin commented Jan 14, 2025

This PR:

  • extends the pre-commit configuration:
    • isort, black and pyproject-flake8 for Python code (all three tools are configured via pyproject.toml);
    • check-yaml for yaml files;
    • actionlint for GitHub workflows;
    • end-of-file-fixer and trailing-whitespace for all text files in the repo;
    • ci entry with the configuration for pre-commit ci;
  • updates .git-blame-ignore-revs with the changes from Format entire codebase #337;
  • addresses issues identified by flake8 and actionlint.

Depends on #337.

@RobertPincus
Copy link
Member

@skosukhin This seems a good set of automation. We've discussed linting/formatting the Fortran code too but there's no strong consensus on how to do this; I'd be inclined to leave it for now.

@skosukhin skosukhin mentioned this pull request Jan 14, 2025
@skosukhin skosukhin force-pushed the extend-pre-commit-config branch from 3744aef to b79ef90 Compare January 14, 2025 15:51
@skosukhin skosukhin force-pushed the extend-pre-commit-config branch from 1600406 to f2897de Compare January 14, 2025 16:01
@skosukhin skosukhin force-pushed the extend-pre-commit-config branch from f2897de to f44db57 Compare January 14, 2025 16:07
Copy link
Member

@RobertPincus RobertPincus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this @skosukhin

@skosukhin skosukhin merged commit 9507fea into develop Jan 14, 2025
40 checks passed
@RobertPincus RobertPincus deleted the extend-pre-commit-config branch January 14, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants