Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support NEC Aurora compiler #336

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Conversation

skosukhin
Copy link
Collaborator

This updates the CMake scripting to support the NEC SX-Aurora TSUBASA Compiler (a.k.a nfort).

With nfort 5.3.0, all tests pass with -DCMAKE_BUILD_TYPE=Release -DRTE_ENABLE_SP=OFF (i.e. -O3). With -DRTE_ENABLE_SP=ON, all tests pass only with -O1. Any higher optimization level makes check_equivalence_sw_g112 fail with:

   Changing TSI fails
   halving/doubling fails
   Incrementing with 1scl fails
   Incrementing with 2str fails
   Incrementing with nstr fails

@RobertPincus
Copy link
Member

@skosukhin You want to merge the PR even under these circumstances?

@skosukhin
Copy link
Collaborator Author

@skosukhin You want to merge the PR even under these circumstances?

Yes, please. To be honest, I still think that there is something strange with the test. I recall problems with it on LUMI with Cray compiler (magically disappeared in #334). If I remember correctly, it's also sensitive to the version of NVHPC in use (I can't find the exact reason for switching to NVHPC 24.9 in Levante CI). The test itself might be fine. Maybe the compilers cannot handle it properly. We will see, I guess.

Copy link
Member

@RobertPincus RobertPincus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skosukhin Sorry this is so awkward but thanks for the support.

@RobertPincus RobertPincus merged commit 0a823c0 into develop Jan 13, 2025
41 checks passed
@RobertPincus RobertPincus deleted the support-nec-aurora-compiler branch January 13, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants