Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally produce shared libraries #335

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

skosukhin
Copy link
Collaborator

No description provided.

@skosukhin
Copy link
Collaborator Author

We should probably change some CI jobs to build the shared libraries but I have no idea how to check that we get the expected result.

@RobertPincus
Copy link
Member

@skosukhin This PR replaces the building of static libraries with the building of shared libraries? Any downsides to this?

@skosukhin
Copy link
Collaborator Author

skosukhin commented Jan 8, 2025

When configured with -DBUILD_SHARED_LIBS=OFF (by default), the build system produces static libraries as before. If the option is set to ON, shared libraries are produced.

UPD: The option is documented here.

@RobertPincus RobertPincus self-requested a review January 8, 2025 20:51
Copy link
Member

@RobertPincus RobertPincus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@RobertPincus RobertPincus merged commit af6c185 into develop Jan 8, 2025
42 checks passed
@RobertPincus RobertPincus deleted the shared-libraries branch January 8, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants