From 375255cbab07480ddfcece37b2d39463572580b3 Mon Sep 17 00:00:00 2001 From: Deepak Cherian Date: Mon, 17 Feb 2025 20:37:18 -0700 Subject: [PATCH 1/2] Fix getsize benchmark --- icechunk-python/benchmarks/test_benchmark_reads.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/icechunk-python/benchmarks/test_benchmark_reads.py b/icechunk-python/benchmarks/test_benchmark_reads.py index d1f488ce..109a4d3f 100644 --- a/icechunk-python/benchmarks/test_benchmark_reads.py +++ b/icechunk-python/benchmarks/test_benchmark_reads.py @@ -48,7 +48,7 @@ def test_time_getsize_key(synth_dataset: Dataset, benchmark) -> None: @benchmark def fn(): for array in synth_dataset.load_variables: - key = f"{synth_dataset.group or ''}/{array}/zarr.json" + key = f"{synth_dataset.group + '/' or ''}{array}/zarr.json" sync(store.getsize(key)) From 7590b3b9fb8c7f514e7c16011b1805f659bd1af8 Mon Sep 17 00:00:00 2001 From: Deepak Cherian Date: Mon, 17 Feb 2025 21:41:11 -0700 Subject: [PATCH 2/2] better --- icechunk-python/benchmarks/test_benchmark_reads.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/icechunk-python/benchmarks/test_benchmark_reads.py b/icechunk-python/benchmarks/test_benchmark_reads.py index 109a4d3f..b1ba9e6e 100644 --- a/icechunk-python/benchmarks/test_benchmark_reads.py +++ b/icechunk-python/benchmarks/test_benchmark_reads.py @@ -48,7 +48,11 @@ def test_time_getsize_key(synth_dataset: Dataset, benchmark) -> None: @benchmark def fn(): for array in synth_dataset.load_variables: - key = f"{synth_dataset.group + '/' or ''}{array}/zarr.json" + if group := synth_dataset.group is not None: + prefix = f"{group}/" + else: + prefix = "" + key = f"{prefix}{array}/zarr.json" sync(store.getsize(key))