Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] errors in xarray page #280

Closed
3 tasks done
callumrollo opened this issue Oct 16, 2024 · 1 comment
Closed
3 tasks done

[Docs] errors in xarray page #280

callumrollo opened this issue Oct 16, 2024 · 1 comment

Comments

@callumrollo
Copy link
Contributor

callumrollo commented Oct 16, 2024

When working through the xarray page of the docs, I encountered a few errors/omissions that added friction to my quick attempt at using icechunk + xarray:

  • import line imports modules IcechunkStore, StorageConfig from icechunk; later icechunk.StorageConfig is called, which fails as icechunk itself was not imported.
  • ds = xr.tutorial.open_dataset('rasm') requires the packages pooch and netCDF4 to be installed, this should be included in the instructions
  • Final line states that Notice that this second xarray.Dataset has a time dimension of length 18 whereas the first has a time dimension of length 36, but the first has dimenstions (y: 205, x: 275, time: 18). I think this is just a copy-paste error when making the docs

I will submit 3 PRs to remedy these. Looking forward to working with this package!

@paraseba
Copy link
Collaborator

Closed by @callumrollo PRs. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants