Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19347] Wrong encapsulation in ParticipantMessageData header #3782

Closed
1 task done
cathaysia opened this issue Aug 4, 2023 · 3 comments · Fixed by #3784
Closed
1 task done

[19347] Wrong encapsulation in ParticipantMessageData header #3782

cathaysia opened this issue Aug 4, 2023 · 3 comments · Fixed by #3784
Labels
bug Issue to report a bug

Comments

@cathaysia
Copy link

cathaysia commented Aug 4, 2023

Is there an already existing issue for this?

  • I have searched the existing issues

Expected behavior

Currently, wlp data declares its serialization method as plcdr during the serialization process, but actually the serialization method is in accordance with cdr. Is this part of the description wrong?

change->serializedPayload.data[1] = PL_DEFAULT_ENCAPSULATION;

@cathaysia cathaysia added the triage Issue pending classification label Aug 4, 2023
@cathaysia
Copy link
Author

image

This specification explicitly ask for the cdr format, so a fix is needed here

@MiguelCompany MiguelCompany added bug Issue to report a bug and removed triage Issue pending classification labels Aug 4, 2023
@EduPonz EduPonz changed the title The heade of ParticipantMessageData. [19347] Wrong encapsulation in ParticipantMessageData header Aug 4, 2023
@EduPonz
Copy link

EduPonz commented Aug 4, 2023

Hi @cathaysia,

Thanks for the report! I have submitted a PR to fix it, could you please verify on your end?

@cathaysia
Copy link
Author

Except for a little comment problem, everything else is perfect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue to report a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants