Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to ignore embedded thirdparty dependencies [12638] #2251

Closed
alsora opened this issue Oct 6, 2021 · 3 comments
Closed

Allow to ignore embedded thirdparty dependencies [12638] #2251

alsora opened this issue Oct 6, 2021 · 3 comments

Comments

@alsora
Copy link
Contributor

alsora commented Oct 6, 2021

Fast-DDS contains a bunch of dependencies in the thirdparty directory.
Some of these (e.g. asio, fastcdr, etc) are git submodules and, unless the FORCE option is specified, can be provided by the system.
However, it looks like this is not the case for all the dependencies: boost, filewatch and nlohmann-json are always included (and built) from the thirdparty directory regardless of whether they could be provided by the system.

This can cause problems when cross-compiling fast-dds and when using package managers such as conan.

It would be good if there was a way to control all of these dependencies.

Note: I noticed this because of an error caused by different versions of boost present in my system.

@MiguelCompany MiguelCompany changed the title Allow to ignore embedded thirdparty dependencies Allow to ignore embedded thirdparty dependencies [12638] Oct 6, 2021
@MiguelCompany
Copy link
Member

I think this is more related to what we export, instead of what we use. Seems to me it is similar to #1994, and it is possible that the fix proposed in #1998 would also apply here.

@MiguelCompany
Copy link
Member

@alsora PR #1998 has been merged and is part of release 2.5.0. Could you please check if this has been solved?

@JLBuenoLopez
Copy link
Contributor

I am going to close this issue due to inactivity. A fix has been done and no feedback from the user has been received. @alsora, feel free to reopen if the issue is still happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants