Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Written Feedback for Project 01 #19

Open
brockwc opened this issue Mar 5, 2019 · 0 comments
Open

Written Feedback for Project 01 #19

brockwc opened this issue Mar 5, 2019 · 0 comments

Comments

@brockwc
Copy link

brockwc commented Mar 5, 2019

Hey guys,

Your first group project, 50 for 50, met the requirements as laid out in the project spec sheet (https://git.generalassemb.ly/sf-wdi-51/project-01/blob/master/README.md). Here are some notes to consider in future:

From a frontend perspective:

  • the final look of the project is strong. It was nice to see a cohesive design using a distinct colour theme and clean font styling.
  • I liked the addition of outside libraries and plugins to add to the look and feel of the site, especially the clickable map.
  • your HTML is decently semantic and the CSS code is good but poorly organized/structured
  • I would have liked to see an additional page explaining the app or introducing the team behind it just to further show your frontend skill

From a backend perspective:

  • the project meets our requirements.
  • it's nice to see google auth implemented but it doesn't seem important (ie. it should block me from doing things until I log in and there is no indication on the frontend that a user has actually signed in)
  • the current deployed version of the site does not have a working version of the playlist feature
  • the current deployed version is erroring out in the console
  • deployed versions of the site should ideally hold the working version of the project
  • backend code organization (models, server, etc.) has well-organized code and demonstrates a good understanding of the concepts we're learning in class

Presentation and README:

  • in future, take a little time to practice the presentation and fill in the README with images of app, screenshots of code or specific features, even recorded gifs would be a nice touch
  • from an outside perspective it seemed like your group worked well together but (judging by commit history alone) the work did not look evenly balanced
  • excellent amount of commits and good job attaching helpful commit messages to each one (for the most part)
@brockwc brockwc changed the title Written Feedback fro Project 01 Written Feedback for Project 01 Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant