Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 read cognito values from environment variables instead of a file #45

Open
shankari opened this issue Jun 1, 2023 · 1 comment
Open

Comments

@shankari
Copy link
Contributor

shankari commented Jun 1, 2023

If the values have to be read from a file, then, in a multi-tenant environment, we will need separate images for each tenant.
The whole point of the dynamic config is to avoid that - so that we can reuse the same docker image for all tenants.
We cannot put the cognito values into the dynamic config for obvious reasons, but we can and should put it into environment variables so that we can configure different instances of the image correctly.

@shankari
Copy link
Contributor Author

shankari commented Jun 1, 2023

I have a partial fix checked in for now.
927817a

However, we should think about this carefully and clean it up a bit.
For example, we might want to reconsider whether we even need to read cognito values from a file given that we are going to support environment variables anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant