Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Download json dump" causes crash for some days #936

Open
JGreenlee opened this issue Jul 13, 2023 · 3 comments
Open

"Download json dump" causes crash for some days #936

JGreenlee opened this issue Jul 13, 2023 · 3 comments

Comments

@JGreenlee
Copy link

JGreenlee commented Jul 13, 2023

I observe a crash on attempting to export certain days of travel. It affects 1.3.3 (currently on production) and 1.3.7 (currently on staging). Both iOS and Android.

Steps to reproduce:

  • Sign into my OPCode (or another affected user)
  • Profile > Download json dump
  • Choose May 6 (or other affected day)
  • Confirm, popup closes
  • Wait for ~10-30 seconds
  • App crashes, 'share' menu never appears

My speculation is that this only affects days with a lot of travel - maybe the sensed data is being retrieved in some unsafe way such that we run out of memory

@Abby-Wheelis
Copy link
Member

Attempts to reproduce this, testing with @JGreenlee's code on May 6th:

  • iPhone8 - takes about 5 seconds, but loads just fine
  • SamsungGalaxy - took about 8 seconds but loading fine
  • iPhoneSE - took about 7 seconds loading still fine

Unfortunately, I have not been able to reproduce the issue, I even tried one day on the Galaxy where I had 20 trips recorded and it loaded to the share page relatively quickly.

I did notice on the iPhone especially that this date-picker is not user friendly, I frequently somehow loaded a day when only trying to arrow between months. I think switching out the date picker should be something we target in the migration process.

I'm also noticing that there's a popup warning me I that I have to have email configured, even though I do have it on the phone - not entirely sure if that is the desired behavior, and it's only happening on the iPhones.

@JGreenlee
Copy link
Author

Interesting. Maybe it is more device-specific than I thought. I'll try some others.

@shankari
Copy link
Contributor

shankari commented Jul 14, 2023

I'm also noticing that there's a popup warning me I that I have to have email configured, even though I do have it on the phone - not entirely sure if that is the desired behavior, and it's only happening on the iPhones.

I think that is because the mail app only works with Apple Mail, not with Gmail (at least on the basic configuration). We had a lot of people who were only using gmail, and then they complained that the email wouldn't work. I'd be OK with removing that popup if we can do better with the error messages. I am just not very patient about creating popups for all the error conditions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants