New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

❌📙 Review the need for diary.js #1017

Open

sebastianbarry opened this issue Oct 19, 2023 · 1 comment

sebastianbarry commented Oct 19, 2023

This discussion came up in e-mission/e-mission-phone#1062 (comment) in @shankari comment e-mission/e-mission-phone#1062 (comment)

I saw the comment related to this, but I also wonder where we are using emission.main.diary any more. It used to be in main.js for the routing, but we have also switched to react routing now, correct? can't we just remove this file?

We should look into the need for this file, and remove it if it is unnecessary now that we do routing through React

The text was updated successfully, but these errors were encountered:

sebastianbarry changed the title ~~Review the need foor diary.js~~ ❌📙 Review the need for diary.js

JGreenlee commented Oct 30, 2023

I think we should remove diary.js once e-mission/e-mission-phone#1064 and e-mission/e-mission-phone#1086 are done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment