Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to NC 23 #40

Open
lanawwas opened this issue Dec 3, 2021 · 9 comments
Open

Add support to NC 23 #40

lanawwas opened this issue Dec 3, 2021 · 9 comments

Comments

@lanawwas
Copy link

lanawwas commented Dec 3, 2021

This app cannot be installed because the following dependencies are not fulfilled:
Server version 21 or lower is required.

@BodoWitcha
Copy link

As an administrator of a comic book archive the support on new versions of NC is very important.
I second the request.

@manuelkamp
Copy link

it worked for me today

@BodoWitcha
Copy link

@manualkamp - Thanks. It worked for me too.

@ickam
Copy link

ickam commented Feb 27, 2022

Guys, does it save progress for you? I tried NC 22 snap package, as well as 23 run from docker and neither of them saves read position, much to my annoyance

@sysadminstory
Copy link

My PR #42 should fix this (I hope !)

@Mangleuz
Copy link

My PR #42 should fix this (I hope !)

And it seems it did! :) Thank you for your wonderful contribution to the splendid app. It has minor quirks, but the really worst for all on Nextcloud 24 is that the reader is not compatible and installable from the app repository ;( (Issue is here). Do you perhaps know if this is just a simple meta-tag issue (23->24), or if it might break some of the nice fixes you have done?

@scurrvy2020
Copy link

#42 didn't seem to fix the sync for me.

@sysadminstory
Copy link

My PR #42 should fix this (I hope !)

And it seems it did! :) Thank you for your wonderful contribution to the splendid app. It has minor quirks, but the really worst for all on Nextcloud 24 is that the reader is not compatible and installable from the app repository ;( (Issue is here). Do you perhaps know if this is just a simple meta-tag issue (23->24), or if it might break some of the nice fixes you have done?

I'm totally not a Nextcloud App developer, so I can not be sure if it should work (I'm still using Nextcloud 22). I tried to replace the deprecated feature I saw during the fix, so Nextcloud 24 could work. You might test editing the info.xml file to change the supported version.

@sysadminstory
Copy link

#42 didn't seem to fix the sync for me.

Do you have any request to a URL ending with "cursor" while changing pages ? What is HTTP return code for those requests ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants