Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AttributesDictionary Json Converter is not reversible #350

Closed
TimPurdum opened this issue Jul 25, 2024 · 1 comment
Closed

AttributesDictionary Json Converter is not reversible #350

TimPurdum opened this issue Jul 25, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@TimPurdum
Copy link
Collaborator

The AttributesDictionaryConverter was written primarily to support serialization to JavaScript. Because of that, the Write output format is not a normal Dictionary/Object, and it is not supported by the Read method.

The custom Write logic probably really belongs in the TypeScript layer. However, it stores .NET type information, and might need to stay where it is (DateTimes, for example, once serialized, look like strings, and we lose the strong typing). Either way, the Read method should support both dictionary/object and array formats, so that it can accept data from different sources.

@TimPurdum TimPurdum added the bug Something isn't working label Jul 25, 2024
@TimPurdum
Copy link
Collaborator Author

Closed with #349

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant