Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests should mock the filesystem consistently #226

Open
snim2 opened this issue Sep 26, 2023 · 0 comments
Open

Tests should mock the filesystem consistently #226

snim2 opened this issue Sep 26, 2023 · 0 comments
Labels
tests

Comments

@snim2
Copy link
Contributor

snim2 commented Sep 26, 2023

In tests/plugins_test.php we create real directories and files on disk (and add the created directories to .gitignore), whereas in tests/dependencies/updater_test.php we use a virtual filesystem to mock OS calls.

It would be preferable to be consistent here, and mock filesystem calls wherever we can.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@snim2