We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Based on the latest (v2.0.0) release, the CHANGELOG states that
Views doesn't accept viewClassName prop anymore, use className instead.
This is not reflected in the ViewProps as well as in the CustomViewProps.
ViewProps
CustomViewProps
Please note that this is a pure TypeScript error as the compiler complains about a missing prop when I try to use className instead of viewClassName.
className
viewClassName
There is an error when used the other way around: the old viewClassName makes TypeScript happy but then the browser is not happy and warns
Warning: React does not recognize the viewClassName prop on a DOM element ...
but this is okay since this prop is clearly not intended to be used anymore.
Please fix this as it is pretty minor :)
I can also submit a PR if you wish.
P.S. Thanks for the awesome lib!
The text was updated successfully, but these errors were encountered:
@scriptex Thanks for the report! I've published version 2.0.1 with fix.
Sorry, something went wrong.
No branches or pull requests
Based on the latest (v2.0.0) release, the CHANGELOG states that
This is not reflected in the
ViewProps
as well as in theCustomViewProps
.Please note that this is a pure TypeScript error as the compiler complains about a missing prop when I try to use
className
instead ofviewClassName
.There is an error when used the other way around: the old
viewClassName
makes TypeScript happy but then the browser is not happy and warnsbut this is okay since this prop is clearly not intended to be used anymore.
Please fix this as it is pretty minor :)
I can also submit a PR if you wish.
P.S. Thanks for the awesome lib!
The text was updated successfully, but these errors were encountered: