Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document base64url_to_bytes #131

Closed
WesleyAC opened this issue Apr 28, 2022 · 1 comment
Closed

Document base64url_to_bytes #131

WesleyAC opened this issue Apr 28, 2022 · 1 comment
Labels
documentation

Comments

@WesleyAC
Copy link

As a user of this library, it was quite surprising that it knows which JSON keys are bytes, and uses base64 to serialize/deserialize them — figuring that out required reading the code. It would be great if the readme mentioned that this encoding was in use, since it is non-standard and specific to this library.
@MasterKale MasterKale mentioned this issue Nov 8, 2022
Merged
@MasterKale
Copy link
Collaborator

Documentation has been added high-up in the README that should address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@WesleyAC @MasterKale