Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

escape_byte_string could accept B: IntoIterator<Item=u8> #612

Open
jakoschiko opened this issue Nov 6, 2024 · 0 comments
Open

escape_byte_string could accept B: IntoIterator<Item=u8> #612

jakoschiko opened this issue Nov 6, 2024 · 0 comments

Comments

@jakoschiko
Copy link
Collaborator

If we change the signature from

pub fn escape_byte_string<B>(bytes: B) -> String
where
    B: AsRef<[u8]>,

to

pub fn escape_byte_string<B>(bytes: B) -> String
where
    B: IntoIterator<Item=u8>,

then we can pass more types to the function, e.g. VecDeque<u8>.

The implementation would not change much because we create an iterator anyway. Current implementation:

let bytes = bytes.as_ref();

bytes
    .iter()
    //...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant