Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logging] Add debug logs for recategorization #753

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

dbajpeyi
Copy link
Collaborator

@dbajpeyi dbajpeyi commented Feb 7, 2025

Reviewer: @GioSensation
Asana:

Description

When an input was re-categorized, log the input and it's target type. This will help debug some of the incoming issues.

Steps to test

  1. Go to https://accounts.oneplus.com/v2/index.html,
  2. Set ddg-autofill-debug to true in session storage for accounts.oneplus.com,
  3. Looking for "recategorized" in console logs. You should see something like:
Screenshot 2025-02-07 at 14 23 36

@dbajpeyi dbajpeyi requested a review from GioSensation February 7, 2025 08:50
@dbajpeyi dbajpeyi force-pushed the dbajpeyi/chore/add-log branch from 59dbef3 to d342f14 Compare February 7, 2025 08:53
Copy link
Member

@GioSensation GioSensation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for being proactive on this, @dbajpeyi ! 🚀

@dbajpeyi dbajpeyi merged commit ac96d46 into main Feb 7, 2025
1 check passed
@dbajpeyi dbajpeyi deleted the dbajpeyi/chore/add-log branch February 7, 2025 09:35
CDRussell added a commit to duckduckgo/Android that referenced this pull request Feb 11, 2025
Task/Issue URL:
https://app.asana.com/0/1209376474235068/1209376474235068
Autofill Release:
https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/16.2.1


## Description
Updates Autofill to version
[16.2.1](https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/16.2.1).

### Autofill 16.2.1 release notes
## What's Changed
* Update password-related json files (2025-01-31) by @daxmobile in
duckduckgo/duckduckgo-autofill#750
* [Logging] Add debug logs for recategorization by @dbajpeyi in
duckduckgo/duckduckgo-autofill#753
* [Formatters] re-add partial save logic behind a feature toggle by
@dbajpeyi in duckduckgo/duckduckgo-autofill#757


**Full Changelog**:
duckduckgo/duckduckgo-autofill@16.2.0...16.2.1

## Steps to test
This release has been tested during autofill development. For smoke test
steps see [this
task](https://app.asana.com/0/1198964220583541/1200583647142330/f).

---------

Co-authored-by: dbajpeyi <3018923+dbajpeyi@users.noreply.github.com>
Co-authored-by: Craig Russell <1336281+CDRussell@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants