feat: check for form class/id #742
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4d068f7 to
5a30f96
Compare
5a30f96 to
1c5552f
Compare
| if (formLikeContainer) { | ||
| const containerInputs = formLikeContainer.querySelectorAll(this.matching.cssSelector('formInputsSelector')); | ||
| const submitButtons = formLikeContainer.querySelectorAll(this.matching.cssSelector('submitButtonSelector')); | ||
| if (containerInputs.length <= this.options.maxInputsPerForm && submitButtons.length > 0) { |
There was a problem hiding this comment.
I think you might still need to check for && inputs.length > 1 to avoid getting trapped in something like .class-form-row.
Suggested change
| if (containerInputs.length <= this.options.maxInputsPerForm && submitButtons.length > 0) { | |
| if (containerInputs.length <= this.options.maxInputsPerForm && inputs.length > 1 && submitButtons.length > 0) { |
And you'll need recursion in that case. Adding the submit button requirement can also be revisited. Some forms might not have the submit button at all, or it can be some div.
But overall this seems directionally correct. Nice work!
| // Try using closest() with form-like selectors | ||
| const formSelectors = [ | ||
| // Explicit forms first | ||
| 'form:not([role=search])', |
There was a problem hiding this comment.
If the input has a parent form, you'd get it with input.form, so this is redundant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer:
Asana:
Description
Steps to test