Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duck Player - YouTube error detection fix #1519

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

mgurgel
Copy link
Contributor

@mgurgel mgurgel commented Feb 26, 2025

Description

Fixes a selector that prevented a YouTube error from being detected before the mutation observer is in place.

Testing Steps

This one is hard to test. Might be better to demo in person.

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@mgurgel mgurgel requested review from shakyShane and a team as code owners February 26, 2025 15:17
Copy link

netlify bot commented Feb 26, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit dda4430
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/67bf308896c6890008c6fca5
😎 Deploy Preview https://deploy-preview-1519--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

[Beta] Generated file diff

Time updated: Wed, 26 Feb 2025 15:18:54 GMT

Android
    - android/pages/duckplayer/dist/index.js

File has changed

Integration
    - integration/pages/duckplayer/dist/index.js

File has changed

Windows
    - windows/pages/duckplayer/dist/index.js

File has changed

Apple
    - dist/pages/duckplayer/dist/index.js
  • dist/pages/duckplayer/index.html

File has changed

@mgurgel mgurgel merged commit 993d679 into main Feb 26, 2025
15 checks passed
@mgurgel mgurgel deleted the mgurgel/duckplayer-error-detection-fix branch February 26, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants