Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

making the favicon component re-usable #1510

Merged
merged 4 commits into from
Feb 25, 2025
Merged

making the favicon component re-usable #1510

merged 4 commits into from
Feb 25, 2025

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Feb 25, 2025

Asana Task/Github Issue: https://app.asana.com/0/1201141132935289/1209498415666878

Description

  • the Favicon component I developed for the new tab page is perfect to re-use in the history view, so this PR just decouples it.

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

Copy link

netlify bot commented Feb 25, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit b83076b
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/67bdd9e33897a50008c7f429
😎 Deploy Preview https://deploy-preview-1510--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shakyShane shakyShane mentioned this pull request Feb 25, 2025
10 tasks
@shakyShane
Copy link
Contributor Author

shakyShane commented Feb 25, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@shakyShane shakyShane mentioned this pull request Feb 25, 2025
8 tasks
Copy link

github-actions bot commented Feb 25, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Feb 25, 2025

[Beta] Generated file diff

Time updated: Tue, 25 Feb 2025 14:56:26 GMT

Integration
    - integration/pages/new-tab/dist/index.css
  • integration/pages/new-tab/dist/index.js

File has changed

Windows
    - windows/pages/new-tab/dist/index.css
  • windows/pages/new-tab/dist/index.js

File has changed

Apple
    - dist/pages/new-tab/dist/index.css
  • dist/pages/new-tab/dist/index.js

File has changed

@shakyShane shakyShane marked this pull request as ready for review February 25, 2025 14:41
@shakyShane shakyShane requested review from mgurgel and a team as code owners February 25, 2025 14:41
@shakyShane shakyShane requested a review from a team February 25, 2025 14:49
@madblex madblex requested review from a team and removed request for a team February 25, 2025 14:55
@shakyShane shakyShane mentioned this pull request Feb 25, 2025
9 tasks
@shakyShane shakyShane merged commit 24dda52 into main Feb 25, 2025
14 checks passed
@shakyShane shakyShane deleted the shane/favicons branch February 25, 2025 16:09
@madblex madblex requested review from a team and alistairjcbrown and removed request for a team and alistairjcbrown February 26, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants