Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed flakey test with comparing titles #1508

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Feb 24, 2025

Asana Task/Github Issue: https://app.asana.com/0/1201141132935289/1209485338280155

Description

  • whilst working on the History page, I noticed that some tests immediately compare the title, when they should wait instead.

Testing Steps

  • Just tests, nothing to verify

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@shakyShane
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

netlify bot commented Feb 24, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 38fe65b
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/67bc92127c9a6a000848ec92
😎 Deploy Preview https://deploy-preview-1508--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Feb 24, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Feb 24, 2025

[Beta] Generated file diff

Time updated: Mon, 24 Feb 2025 15:37:52 GMT

@shakyShane shakyShane marked this pull request as ready for review February 24, 2025 15:32
@shakyShane shakyShane requested review from mgurgel and a team as code owners February 24, 2025 15:32
mgurgel
mgurgel previously approved these changes Feb 24, 2025
@shakyShane shakyShane merged commit 9e5c692 into main Feb 24, 2025
13 checks passed
@shakyShane shakyShane deleted the 02-24-fixed_flakey_test_with_comparing_titles branch February 24, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants