Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

history: adding multi-select #1487

Merged
merged 15 commits into from
Feb 27, 2025
Merged

history: adding multi-select #1487

merged 15 commits into from
Feb 27, 2025

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Feb 12, 2025

Asana Task/Github Issue: https://app.asana.com/0/1201141132935289/1209499786700961

Description

  • Added support for selections + keyboard interactions
  • Conducting zoom walk-throughs

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@shakyShane
Copy link
Contributor Author

shakyShane commented Feb 12, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@shakyShane shakyShane mentioned this pull request Feb 12, 2025
10 tasks
Copy link

github-actions bot commented Feb 12, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Feb 12, 2025

[Beta] Generated file diff

Time updated: Thu, 27 Feb 2025 09:33:42 GMT

Integration
    - integration/pages/history/dist/index.css
  • integration/pages/history/dist/index.js
  • integration/pages/history/icons/clock.svg
  • integration/pages/history/index.html
  • integration/pages/history/locales/en/history.json

File has changed

Windows
    - windows/pages/history/dist/index.css
  • windows/pages/history/dist/index.js
  • windows/pages/history/icons/clock.svg
  • windows/pages/history/index.html
  • windows/pages/history/locales/en/history.json

File has changed

Apple
    - dist/pages/history/dist/index.css
  • dist/pages/history/dist/index.js
  • dist/pages/history/icons/clock.svg
  • dist/pages/history/index.html
  • dist/pages/history/locales/en/history.json

File has changed

New Files
    - integration/pages/history/company-icons/fake.svg
  • integration/pages/history/company-icons/other-dark.svg
  • integration/pages/history/company-icons/other.svg
  • integration/pages/history/dist/clear-4G6WB4R2.svg
  • integration/pages/history/dist/clear-dark-G37N3SFY.svg
  • integration/pages/history/icons/backdrop.svg
  • integration/pages/history/icons/clear-dark.svg
  • integration/pages/history/icons/clear.svg
  • windows/pages/history/company-icons/fake.svg
  • windows/pages/history/company-icons/other-dark.svg
  • windows/pages/history/company-icons/other.svg
  • windows/pages/history/dist/clear-4G6WB4R2.svg
  • windows/pages/history/dist/clear-dark-G37N3SFY.svg
  • windows/pages/history/icons/backdrop.svg
  • windows/pages/history/icons/clear-dark.svg
  • windows/pages/history/icons/clear.svg
  • dist/pages/history/company-icons/fake.svg
  • dist/pages/history/company-icons/other-dark.svg
  • dist/pages/history/company-icons/other.svg
  • dist/pages/history/dist/clear-4G6WB4R2.svg
  • dist/pages/history/dist/clear-dark-G37N3SFY.svg
  • dist/pages/history/icons/backdrop.svg
  • dist/pages/history/icons/clear-dark.svg
  • dist/pages/history/icons/clear.svg

❌ File only exists in new changeset

Base automatically changed from shane/history-selections to main February 13, 2025 16:54
@shakyShane shakyShane force-pushed the shane/history-multi-select branch from cdcaf8a to f2e558c Compare February 13, 2025 16:55
Copy link

netlify bot commented Feb 13, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 27db7cb
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/67c0313cef91b1000872136f
😎 Deploy Preview https://deploy-preview-1487--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shakyShane shakyShane mentioned this pull request Feb 15, 2025
8 tasks
@shakyShane shakyShane force-pushed the shane/history-multi-select branch 3 times, most recently from bb5b91f to b2a3702 Compare February 25, 2025 14:39
@shakyShane shakyShane changed the base branch from main to shane/favicons February 25, 2025 14:39
@shakyShane shakyShane force-pushed the shane/history-multi-select branch 2 times, most recently from 6a65d3c to e3740f9 Compare February 25, 2025 15:04
@shakyShane shakyShane mentioned this pull request Feb 25, 2025
9 tasks
Base automatically changed from shane/favicons to main February 25, 2025 16:09
@shakyShane shakyShane force-pushed the shane/history-multi-select branch from afa02de to 24a5a29 Compare February 25, 2025 16:09
@shakyShane shakyShane marked this pull request as ready for review February 25, 2025 16:12
@shakyShane shakyShane requested review from mgurgel and a team as code owners February 25, 2025 16:12
@shakyShane shakyShane force-pushed the shane/history-multi-select branch from 24a5a29 to 3bad912 Compare February 26, 2025 09:34
Copy link
Contributor

@mgurgel mgurgel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through the architecture and test builds with Shane over zoom yesterday and reviewed the code again this morning. This is really good 👏

@shakyShane
Copy link
Contributor Author

Merging before ship review, mostly so that changes that come up will be documented as future PRs and not lost in this large change.

@shakyShane shakyShane merged commit 9bf9837 into main Feb 27, 2025
15 checks passed
@shakyShane shakyShane deleted the shane/history-multi-select branch February 27, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants