Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

history: support deleting sidebar time ranges #1480

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Feb 10, 2025

Asana Task/Github Issue: https://app.asana.com/0/1201141132935289/1209366052447227

Description

  • support for deleting a time range

Testing Steps

  • run locally with npm run watch -- --page history -v
  • open the history page with items preloaded, such as http://localhost:8000?history=100
image - click ‘delete all’, or use the icon in the sidebar under ‘all’ - confirm the dialog - ensure you see the empty state Screenshot 2025-02-10 at 15 57 14

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@shakyShane
Copy link
Contributor Author

shakyShane commented Feb 10, 2025

Copy link

github-actions bot commented Feb 10, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Feb 10, 2025

[Beta] Generated file diff

Time updated: Tue, 11 Feb 2025 09:57:38 GMT

Integration
    - integration/pages/history/dist/index.css
  • integration/pages/history/dist/index.js
  • integration/pages/history/locales/en/history.json
  • integration/pages/new-tab/dist/index.js

File has changed

Windows
    - windows/pages/history/dist/index.css
  • windows/pages/history/dist/index.js
  • windows/pages/history/locales/en/history.json
  • windows/pages/new-tab/dist/index.js

File has changed

Apple
    - dist/pages/history/dist/index.css
  • dist/pages/history/dist/index.js
  • dist/pages/history/locales/en/history.json
  • dist/pages/new-tab/dist/index.js

File has changed

New Files
    - integration/pages/history/icons/clock.svg
  • windows/pages/history/icons/clock.svg
  • dist/pages/history/icons/clock.svg

❌ File only exists in new changeset

@shakyShane shakyShane marked this pull request as ready for review February 10, 2025 14:01
@shakyShane shakyShane requested review from mgurgel and a team as code owners February 10, 2025 14:01
@shakyShane shakyShane closed this Feb 10, 2025
@shakyShane shakyShane reopened this Feb 10, 2025
Base automatically changed from 02-10-ntp_default_to_an_empty_query_when_all_is_selected to main February 11, 2025 09:56
@shakyShane shakyShane force-pushed the 02-10-history_support_deleting_sidebar_time_ranges branch from 7798371 to 6a8c868 Compare February 11, 2025 09:56
Copy link

netlify bot commented Feb 11, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 6a8c868
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/67ab1ed7cd5a850008e38491
😎 Deploy Preview https://deploy-preview-1480--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@mgurgel mgurgel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally. Works as described.

@shakyShane shakyShane merged commit 76160aa into main Feb 11, 2025
13 checks passed
@shakyShane shakyShane deleted the 02-10-history_support_deleting_sidebar_time_ranges branch February 11, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants