history: default to an empty query when 'all' is selected #1472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for content-scope-scripts ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
[Beta] Generated file diffTime updated: Mon, 10 Feb 2025 10:43:28 GMT Integration
File has changed Windows
File has changed Apple
File has changed |
shakyShane
commented
Feb 10, 2025
Comment on lines
+75
to
87
| test('selecting `all` resets to an empty query', async ({ page }, workerInfo) => { | ||
| const hp = HistoryTestPage.create(page, workerInfo).withEntries(300); | ||
| await hp.openPage({}); | ||
|
|
||
| // start with a fresh range query | ||
| await hp.selectsRange('today'); | ||
| await hp.selectsToday(); | ||
| await hp.didMakeNthQuery({ nth: 1, query: { range: 'today' } }); | ||
|
|
||
| // click 'all' (to reset) | ||
| await hp.selectsRange('all'); | ||
| await hp.selectsAll(); | ||
|
|
||
| // ensure it's a full reset | ||
| await hp.didMakeNthQuery({ nth: 2, query: { term: '' } }); |
There was a problem hiding this comment.
This test was skipped before, but is now passing :)
9 tasks
vkraucunas
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Task/Github Issue: https://app.asana.com/0/1201141132935289/1209364150538084
Description
Testing Steps
Checklist
Please tick all that apply: