Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ntp: support auto-open + settings link #1351

Merged
merged 2 commits into from
Dec 23, 2024
Merged

ntp: support auto-open + settings link #1351

merged 2 commits into from
Dec 23, 2024

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Dec 23, 2024

Asana Task/Github Issue: https://app.asana.com/0/1201141132935289/1209037462245829/f

Description

  • Allow the customizer to be auto-opened via initial setup, or subscription message
  • Support opening settings

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@shakyShane shakyShane mentioned this pull request Dec 23, 2024
14 tasks
Copy link

netlify bot commented Dec 23, 2024

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 67b68e7
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/676986fbbec71a0008724fe2
😎 Deploy Preview https://deploy-preview-1351--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shakyShane
Copy link
Contributor Author

shakyShane commented Dec 23, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

github-actions bot commented Dec 23, 2024

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Dec 23, 2024

[Beta] Generated file diff

Time updated: Mon, 23 Dec 2024 15:52:24 GMT

Integration
    - integration/pages/new-tab/dist/index.js

File has changed

Windows
    - windows/pages/new-tab/dist/index.js

File has changed

Apple
    - dist/pages/new-tab/dist/index.js

File has changed

@shakyShane shakyShane marked this pull request as ready for review December 23, 2024 15:41
@shakyShane shakyShane requested review from mgurgel and a team as code owners December 23, 2024 15:41
@shakyShane shakyShane merged commit 4c6371f into main Dec 23, 2024
15 checks passed
@shakyShane shakyShane deleted the shane/ntp-auto-open branch December 23, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants