Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Conditional Clicking in Broker Protection #1141

Merged
merged 18 commits into from
Nov 21, 2024
Merged

Conversation

brianhall
Copy link
Contributor

@brianhall brianhall commented Oct 18, 2024

Asana Task/Github Issue: https://app.asana.com/0/72649045549333/1208561106797172/f

Description

Adds support for conditional clicking in Broker Protection, allowing the click action to evaluate the user's profile in order to determine which element gets clicked.

Testing Steps

  • Run test-suites
  • Drag/drop into XCode

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@brianhall brianhall requested review from shakyShane and a team as code owners October 18, 2024 19:53
Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 7876fb9
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/673f33ac9dd32100088357ea
😎 Deploy Preview https://deploy-preview-1141--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Oct 18, 2024

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Oct 18, 2024

[Beta] Generated file diff

Time updated: Thu, 21 Nov 2024 13:21:47 GMT

Integration
    - integration/contentScope.js

File has changed

Windows
    - windows/contentScope.js

File has changed

Apple
    - dist/contentScopeIsolated.js

File has changed

Copy link
Contributor

@jonathanKingston jonathanKingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some eslint warnings here, I assume you're still working. Place it as a draft :).

Is there a task for these changes?

@brianhall brianhall marked this pull request as draft October 18, 2024 23:30
@brianhall
Copy link
Contributor Author

@jonathanKingston Added associated task. Apologies, should have started with draft PR as I was just stashing changes for the weekend.

@brianhall brianhall changed the base branch from main to bhall/support-conditional-actions October 21, 2024 19:01
Base automatically changed from bhall/support-conditional-actions to main October 23, 2024 19:17
@brianhall brianhall marked this pull request as ready for review October 23, 2024 21:47
@brianhall brianhall dismissed jonathanKingston’s stale review November 21, 2024 13:31

Filed follow-up task to lint operators at the source.

@brianhall brianhall merged commit 389144d into main Nov 21, 2024
13 checks passed
@brianhall brianhall deleted the bhall/support-choices branch November 21, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants