-
Notifications
You must be signed in to change notification settings - Fork 942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add blocking algorithm #5370
Merged
CrisBarreiro
merged 24 commits into
develop
from
feature/cris/malicious-site-protection/load-initial-dataset
Jan 30, 2025
Merged
Add blocking algorithm #5370
CrisBarreiro
merged 24 commits into
develop
from
feature/cris/malicious-site-protection/load-initial-dataset
Jan 30, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
2 tasks
e99a589
to
41dbcee
Compare
21 tasks
3932394
to
13cfb3a
Compare
41dbcee
to
45d1aaa
Compare
13cfb3a
to
8d0f3b0
Compare
45d1aaa
to
ca1717c
Compare
8d0f3b0
to
0b7f33d
Compare
212e3b7
to
7c5e5c2
Compare
615f371
to
7fd8100
Compare
7c5e5c2
to
54f233d
Compare
7fd8100
to
c24dff3
Compare
54f233d
to
0f7697a
Compare
0f7697a
to
7c8c545
Compare
3fb96e8
to
601db6b
Compare
d585fa1
to
e310dad
Compare
2c3627c
to
cfc8cea
Compare
1ea8bd3
to
768449f
Compare
cmonfortep
reviewed
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some questions about the insert, if that's the expected behavior I'm good here.
...m/duckduckgo/malicioussiteprotection/impl/data/embedded/MaliciousSiteEmbeddedDataProvider.kt
Outdated
Show resolved
Hide resolved
...impl/src/main/kotlin/com/duckduckgo/malicioussiteprotection/impl/data/db/MaliciousSiteDao.kt
Outdated
Show resolved
Hide resolved
db4d9bc
to
bad45a7
Compare
768449f
to
d6c864d
Compare
50 tasks
f20c37b
to
9622274
Compare
9622274
to
8770d6e
Compare
This was referenced Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1207151848931036/f
Also includes: https://app.asana.com/0/72649045549333/1208870183150418/f
Description
Steps to test this PR
Pre-requisites
enableMaliciousSiteProtection
underandroidBrowserConfig
Note
Since this implementation only shows a toast, my recommendation is to do the testing along with #5416
Feature 1
UI changes
n/a, toast is temporary, an error page will be added in the next PR