Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blocking algorithm #5370

Merged

Conversation

CrisBarreiro
Copy link
Contributor

@CrisBarreiro CrisBarreiro commented Dec 9, 2024

Task/Issue URL: https://app.asana.com/0/72649045549333/1207151848931036/f
Also includes: https://app.asana.com/0/72649045549333/1208870183150418/f

Description

  • Add logic to keep a malicious site dataset up-to-date
  • Add blocking algorithm for malicious sites (temporarily show a snackbar whenever a site is identified as malicious)
    • Add algorithm to determine whether a URL is malicious or not. Details are described here (Approach A, "Implement MaliciousSiteDetection client library that" section). API was discussed here

Steps to test this PR

Pre-requisites

  • Enable enableMaliciousSiteProtection under androidBrowserConfig

Note

Since this implementation only shows a toast, my recommendation is to do the testing along with #5416

Feature 1

UI changes

n/a, toast is temporary, an error page will be added in the next PR

Copy link
Contributor Author

CrisBarreiro commented Dec 9, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@CrisBarreiro CrisBarreiro force-pushed the feature/cris/malicious-site-protection/load-initial-dataset branch 2 times, most recently from e99a589 to 41dbcee Compare December 10, 2024 10:26
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/malicious-site-protection/intercept-requests branch from 3932394 to 13cfb3a Compare December 10, 2024 10:29
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/malicious-site-protection/load-initial-dataset branch from 41dbcee to 45d1aaa Compare December 10, 2024 10:29
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/malicious-site-protection/intercept-requests branch from 13cfb3a to 8d0f3b0 Compare December 10, 2024 10:49
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/malicious-site-protection/load-initial-dataset branch from 45d1aaa to ca1717c Compare December 10, 2024 10:50
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/malicious-site-protection/intercept-requests branch from 8d0f3b0 to 0b7f33d Compare December 10, 2024 13:37
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/malicious-site-protection/load-initial-dataset branch 2 times, most recently from 212e3b7 to 7c5e5c2 Compare December 10, 2024 15:27
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/malicious-site-protection/intercept-requests branch from 615f371 to 7fd8100 Compare December 11, 2024 14:03
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/malicious-site-protection/load-initial-dataset branch from 7c5e5c2 to 54f233d Compare December 11, 2024 14:03
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/malicious-site-protection/intercept-requests branch from 7fd8100 to c24dff3 Compare December 11, 2024 14:12
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/malicious-site-protection/load-initial-dataset branch from 54f233d to 0f7697a Compare December 11, 2024 14:12
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/malicious-site-protection/load-initial-dataset branch from 0f7697a to 7c8c545 Compare December 16, 2024 10:47
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/malicious-site-protection/intercept-requests branch from 3fb96e8 to 601db6b Compare December 16, 2024 17:31
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/malicious-site-protection/load-initial-dataset branch 2 times, most recently from d585fa1 to e310dad Compare December 17, 2024 09:21
@CrisBarreiro CrisBarreiro marked this pull request as ready for review December 17, 2024 09:42
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/malicious-site-protection/intercept-requests branch from 2c3627c to cfc8cea Compare December 18, 2024 15:41
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/malicious-site-protection/load-initial-dataset branch from 1ea8bd3 to 768449f Compare December 18, 2024 15:42
Copy link
Contributor

@cmonfortep cmonfortep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some questions about the insert, if that's the expected behavior I'm good here.

@CrisBarreiro CrisBarreiro force-pushed the feature/cris/malicious-site-protection/intercept-requests branch from db4d9bc to bad45a7 Compare December 19, 2024 17:10
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/malicious-site-protection/load-initial-dataset branch from 768449f to d6c864d Compare December 19, 2024 17:11
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/malicious-site-protection/load-initial-dataset branch from f20c37b to 9622274 Compare January 30, 2025 10:32
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/malicious-site-protection/load-initial-dataset branch from 9622274 to 8770d6e Compare January 30, 2025 10:44
@CrisBarreiro CrisBarreiro merged commit 5a3aa6e into develop Jan 30, 2025
6 checks passed
@CrisBarreiro CrisBarreiro deleted the feature/cris/malicious-site-protection/load-initial-dataset branch January 30, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants