Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Content visible for a split section after tapping "clear all tabs and data" #4858

Closed
vext01 opened this issue Aug 5, 2024 · 7 comments

Comments

@vext01
Copy link

vext01 commented Aug 5, 2024

Describe the bug

When you tap "clear all tabs and data" an animation is displayed (fire by default) that signifies permanent deletion of all data. It's a neat UI cue that I find very satisfying.

However after the animation has finished, the page that was visible "pre-burn" flashes up for a fraction of a second, thus spoiling the metaphor.

How to Reproduce

  1. click the fire icon
  2. tap "clear all tabs and data"
  3. marvel at the fire animation
  4. previously visible web page flashes up for a fraction of a second.

Expected behavior

  1. click the fire icon
  2. tap "clear all tabs and data"
  3. marvel at the fire animation
  4. app goes directly back to a blank slate without showing remnants of what was there before.

Environment

- DDG App Version:5.209.2
- Device: Samsung
- OS: Android 14
Copy link
Contributor

github-actions bot commented Aug 5, 2024

Thank you for opening an Issue in our Repository.
The issue has been forwarded to the team and we'll follow up as soon as we have time to investigate.
As stated in our Contribution Guidelines, requests for feedback should be addressed via the Feedback section in the Android app.

@marcosholgado
Copy link
Contributor

Thanks for your report. We are aware of this and currently prioritizing a fix, I'll add this report to it so it can hopefully be added soon to the roadmap.

@vext01
Copy link
Author

vext01 commented Aug 9, 2024

Thanks so much.

Love the app. Thanks for making it!

@anikiki
Copy link
Contributor

anikiki commented Sep 12, 2024

@vext01 Thanks for reporting this. It has been fixed in the latest version (5.213.0).

@vext01
Copy link
Author

vext01 commented Sep 12, 2024

Fantastic! Thank you!

@vext01
Copy link
Author

vext01 commented Sep 13, 2024

Can confirm that this is fixed.

There's a small flicker towards the end of the animation, but it's not a big deal.

@anikiki
Copy link
Contributor

anikiki commented Sep 13, 2024

Thanks @vext01 🎉

@anikiki anikiki closed this as completed Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants