You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We plan to make type improvements in [#1338]. We can't port those to 4.x because they'd be breaking changes and sometimes the normal docblock types interfere with PHPCS. However we can use @* docblock annotations to backport the types and make them show up for everyone using PHPStan. That will help people get their 4.x code ready for 5.x
The text was updated successfully, but these errors were encountered:
Hm, I don't think we need @phpstan- docblocks in many cases, we should fix Coder/PHPCS to not contradict PHPStan. Most work on that is already done or in progress, for example https://www.drupal.org/project/coder/issues/3205017
Kingdutch
changed the title
[4.x] Backport type improvements as @phpstan-* annotations
[4.x] Backport type improvements as @* docblock annotations
Apr 20, 2023
Yeah you're absolutely right! My mind still has to get used to the fact that coder now supports those syntaxes which awesome! 🎉 Adjusted the issue accordingly.
We plan to make type improvements in [#1338]. We can't port those to 4.x because they'd be breaking changes and sometimes the normal docblock types interfere with PHPCS. However we can use
@*
docblock annotations to backport the types and make them show up for everyone using PHPStan. That will help people get their 4.x code ready for 5.xThe text was updated successfully, but these errors were encountered: