Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installing cloudpathlib installs a package called tests #173

Closed
pjbull opened this issue Sep 28, 2021 · 0 comments · Fixed by #219
Closed

Installing cloudpathlib installs a package called tests #173

pjbull opened this issue Sep 28, 2021 · 0 comments · Fixed by #219
Labels
good first issue Good for newcomers

Comments

@pjbull
Copy link
Member

pjbull commented Sep 28, 2021

We use find_packages which will discover the tests folder since it has an __init__.py. This means that when you install cloudpathlib you also end up with a tests package in your site-packages.

cloudpathlib/setup.py

Line 55 in 8e4dcaf

packages=find_packages(),

We should just include cloudpathlib explicitly rather than using find_packages since it is the only one.
@pjbull pjbull added the good first issue Good for newcomers label Mar 2, 2022
@jayqi jayqi linked a pull request Apr 5, 2022 that will close this issue
Don't package tests #219
Merged
@jayqi jayqi closed this as completed in #219 Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't package tests
1 participant
@pjbull