From 1f3ea038dd42ad898d42b5491a7fee8726f00279 Mon Sep 17 00:00:00 2001 From: Ravjot Brar Date: Tue, 4 Apr 2023 10:37:33 -0700 Subject: [PATCH 1/3] remove parentheses from create view logic --- .../dremio/macros/materializations/view/create_view_as.sql | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/dbt/include/dremio/macros/materializations/view/create_view_as.sql b/dbt/include/dremio/macros/materializations/view/create_view_as.sql index 4095b7e9..00670fce 100644 --- a/dbt/include/dremio/macros/materializations/view/create_view_as.sql +++ b/dbt/include/dremio/macros/materializations/view/create_view_as.sql @@ -17,7 +17,6 @@ limitations under the License.*/ {{ sql_header if sql_header is not none }} - create or replace view {{ relation }} as ( - {{ sql }} - ) + create or replace view {{ relation }} as {{ sql }} + {%- endmacro %} From d5b7b6b27eed1f66d032511f430cfe23f47276f8 Mon Sep 17 00:00:00 2001 From: Ravjot Brar Date: Wed, 5 Apr 2023 09:35:04 -0700 Subject: [PATCH 2/3] add changelog --- CHANGELOG.md | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index f9836f97..d1398f28 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,15 @@ +# dbt-dremio 1.5.0 - release May 11, 2023 + +## Features + +## Fixes +- [#167](https://github.com/dremio/dbt-dremio/issues/167) Remove parentheses surrounding views in the create_view_as macro. In more complex queries, the parentheses cause performance issues. + +## Under the Hood + +## Dependency + + # dbt-dremio 1.4.5 - release March 23, 2023 ## Features From 5f75e4f8a3ad981dcc6025028633913c826ecb28 Mon Sep 17 00:00:00 2001 From: Ravjot Brar Date: Wed, 5 Apr 2023 09:57:03 -0700 Subject: [PATCH 3/3] change from fix to under the hood --- CHANGELOG.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index d1398f28..7317ac45 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,10 +3,9 @@ ## Features ## Fixes -- [#167](https://github.com/dremio/dbt-dremio/issues/167) Remove parentheses surrounding views in the create_view_as macro. In more complex queries, the parentheses cause performance issues. ## Under the Hood - +- [#167](https://github.com/dremio/dbt-dremio/issues/167) Remove parentheses surrounding views in the create_view_as macro. In more complex queries, the parentheses cause performance issues. ## Dependency