-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Ping records #5
Comments
Hi, you are totally right, it seems that I never implemented support for the Ping type:
I only used traceroutes in my research, and when I wrote the README I was probably thinking I would also implement ping, but in the end I didn't. |
I won't have time to add support for this in the near term. If you are a bit comfortable with Python, it shouldn't be too hard to do: it has the same basic structure as Traceroute. Instead of a Traceroute record + a list of TracerouteHop records, you'd have a Ping record + a list of PingResult records. I'll happily review a pull request implementing this. |
For documentation, run I just notice that in both cases (PDF and latest source tree), the documentation is missing the format of ping results, the doc ends with this:
|
The README says 'can read all basic Warts data types (ping, traceroute)' but I don't see a Ping result reader? Granted it doesn't throw an error when I load Ping results. Please let me know if I'm misunderstanding this statement or have missed the Ping result reading functionality.
The text was updated successfully, but these errors were encountered: