Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Ping records #5

Open
tkoch96 opened this issue Mar 15, 2021 · 3 comments
Open

Add support for Ping records #5

tkoch96 opened this issue Mar 15, 2021 · 3 comments

Comments

@tkoch96
Copy link

tkoch96 commented Mar 15, 2021

The README says 'can read all basic Warts data types (ping, traceroute)' but I don't see a Ping result reader? Granted it doesn't throw an error when I load Ping results. Please let me know if I'm misunderstanding this statement or have missed the Ping result reading functionality.

@jonglezb
Copy link
Contributor

Hi, you are totally right, it seems that I never implemented support for the Ping type:

$ scamper -c ping -O warts -o ping-example.warts -i 1.1.1.1
$ ./parse_from_stdin.py < ping-example.warts
List(name="default", auto_id=1, manual_id=0)
CycleStart(auto_id=1, manual_id=0)
INFO:warts.base:Ignoring unknown record Unknown(type=7, length=201)
Unknown(type=7, length=201)
CycleStop(cycle_id=1, stop-time=1615819926)

I only used traceroutes in my research, and when I wrote the README I was probably thinking I would also implement ping, but in the end I didn't.

@jonglezb
Copy link
Contributor

I won't have time to add support for this in the near term.

If you are a bit comfortable with Python, it shouldn't be too hard to do: it has the same basic structure as Traceroute. Instead of a Traceroute record + a list of TracerouteHop records, you'd have a Ping record + a list of PingResult records.

I'll happily review a pull request implementing this.

@jonglezb jonglezb changed the title Ping? Add support for Ping records Mar 15, 2021
@jonglezb
Copy link
Contributor

For documentation, run man ./scamper/warts.5 in scampers' source tree. The PDF on CAIDA's website is outdated, there have been new flags added since then.

I just notice that in both cases (PDF and latest source tree), the documentation is missing the format of ping results, the doc ends with this:

Ping response records are written in series. Each record takes the following form:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants