Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run FBA tests on all BiGG models #4

Closed
shalinshah1993 opened this issue Aug 6, 2018 · 3 comments · Fixed by #54
Closed

Run FBA tests on all BiGG models #4

shalinshah1993 opened this issue Aug 6, 2018 · 3 comments · Fixed by #54

Comments

@shalinshah1993
Copy link
Collaborator

From @matthiaskoenig on June 11, 2018 13:2

FBA simulations with all BiGG models should be performed and compared against reference solutions from cobrapy.
BiGG models are not part of the repository, but must be downloaded for testing in CI or locally. Access is via environment variable.

Copied from original issue: shalinshah1993#28

@shalinshah1993
Copy link
Collaborator Author

From @matthiaskoenig on June 11, 2018 13:7

Most of this is implemented in
shalinshah1993@cefc069

This issue depends on #24, i.e. only if FBA is working than it can be run on all BiGG models.

@hemilpanchiwala
Copy link
Member

@matthiaskoenig, @shalinshah1993
Now, all FBA tests of BiGG models are running and passing successfully, so should I link this issue to PR #54 so that it can be closed on PR merge?

Commits Link: c40ef21 9b92496

@matthiaskoenig
Copy link
Collaborator

Yes, link the issue

@hemilpanchiwala hemilpanchiwala linked a pull request Aug 7, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants