fix(network-manager): don't pull in systemd-udev-settle #1552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We get a nice warning about it being deprecated: ``` systemd-udev-settle.service is deprecated. Please fix nm-initrd.service not to pull it in. ``` The service is deprecated because its purpose was to wait for the discovery of all hardware, but it didn't guarantee that (see the systemd-udev-settle man page). NM now runs as an independent service and can deal with devices showing up at any point, but it does need udev to be started. For now just Want/After systemd-udev-trigger.
|
Considering the case - should we be using |
|
cc @bengal |
johannbg
approved these changes
Jun 29, 2021
|
LGTM, thanks. |
jlebon
added a commit
to jlebon/dracut
that referenced
this pull request
Jun 30, 2021
Rawhide systemd warns about this now:
udevadm[445]: systemd-udev-settle.service is deprecated. Please fix
multipathd-configure.service, multipathd.service not to pull it in.
Similarly to dracutdevs#1552, we don't actually need that dependency anyway here.
`multipathd-configure.service` just outputs a file in /etc and shouldn't
need to probe devices, and `multipathd` itself by nature is designed to
handle dynamic udev changes.
So just drop it.
haraldh
approved these changes
Jul 1, 2021
dustymabe
added a commit
to dustymabe/fedora-coreos-config
that referenced
this pull request
Jul 9, 2021
Contains upstream fixes needed to get NM running via systemd+dbus in the initramfs without issues. - dracutdevs/dracut#1547 - dracutdevs/dracut#1548 - dracutdevs/dracut#1552 Needed to get dracut unfrozen: coreos/fedora-coreos-tracker#842 (comment)
dustymabe
added a commit
to dustymabe/fedora-coreos-config
that referenced
this pull request
Jul 9, 2021
Contains upstream fixes needed to get NM running via systemd+dbus in the initramfs without issues. - dracutdevs/dracut#1547 - dracutdevs/dracut#1548 - dracutdevs/dracut#1552 Needed to get dracut unfrozen: coreos/fedora-coreos-tracker#842 (comment)
dustymabe
added a commit
to coreos/fedora-coreos-config
that referenced
this pull request
Jul 9, 2021
Contains upstream fixes needed to get NM running via systemd+dbus in the initramfs without issues. - dracutdevs/dracut#1547 - dracutdevs/dracut#1548 - dracutdevs/dracut#1552 Needed to get dracut unfrozen: coreos/fedora-coreos-tracker#842 (comment)
stewartsmith
pushed a commit
to stewartsmith/fedora-rpms-dracut
that referenced
this pull request
Jun 19, 2022
Also backport a fix to drop requirement on deprecated systemd-udev-settle. - dracutdevs/dracut#1547 - dracutdevs/dracut#1548 - dracutdevs/dracut#1552
HuijingHei
pushed a commit
to HuijingHei/fedora-coreos-config
that referenced
this pull request
Oct 10, 2023
Contains upstream fixes needed to get NM running via systemd+dbus in the initramfs without issues. - dracutdevs/dracut#1547 - dracutdevs/dracut#1548 - dracutdevs/dracut#1552 Needed to get dracut unfrozen: coreos/fedora-coreos-tracker#842 (comment)
HuijingHei
pushed a commit
to HuijingHei/fedora-coreos-config
that referenced
this pull request
Oct 10, 2023
Contains upstream fixes needed to get NM running via systemd+dbus in the initramfs without issues. - dracutdevs/dracut#1547 - dracutdevs/dracut#1548 - dracutdevs/dracut#1552 Needed to get dracut unfrozen: coreos/fedora-coreos-tracker#842 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We get a nice warning about it being deprecated:
The service is deprecated because its purpose was to wait for the
discovery of all hardware, but it didn't guarantee that (see the
systemd-udev-settle man page).
NM now runs as an independent service and can deal with devices showing
up at any point, but it does need udev to be started. For now just
Want/After systemd-udev-trigger.