Skip to content

Commit 48099aa

Browse files
piotrczarnaspiotrczarnas
committed
Fix unit tests for rendering negative values sensors
1 parent 1565793 commit 48099aa

3 files changed

+41
-51
lines changed

‎dqops/src/test/java/com/dqops/sensors/bigquery/column/numeric/ColumnNumericIntegerInRangePercentSensorParametersSpecBigQueryTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -499,7 +499,7 @@ void renderSensor_whenErrorSamplingForProfilingNoTimeSeriesNoDataStream_thenRend
499499
FROM
500500
`%2$s`.`%3$s`.`%4$s` AS analyzed_table
501501
WHERE (%5$s)
502-
AND (NOT (%1$s >= 29 AND %1$s <= 30))
502+
AND (%1$s IS NOT NULL AND NOT (%1$s >= 29 AND %1$s <= 30))
503503
LIMIT 10""";
504504

505505
Assertions.assertEquals(String.format(target_query,

‎dqops/src/test/java/com/dqops/sensors/bigquery/column/numeric/ColumnNumericNonNegativeCountSensorParametersSpecBigQueryTests.java

+20-30
Original file line numberDiff line numberDiff line change
@@ -101,15 +101,14 @@ void renderSensor_whenProfilingNoTimeSeriesNoDataStream_thenRendersCorrectSql()
101101
SELECT
102102
SUM(
103103
CASE
104-
WHEN %s < 0 OR %s IS NULL THEN 0
105-
ELSE 1
104+
WHEN %s >= 0 THEN 1
105+
ELSE 0
106106
END
107107
) AS actual_value
108108
FROM `%s`.`%s`.`%s` AS analyzed_table
109109
WHERE (%s)""";
110110

111111
Assertions.assertEquals(String.format(target_query,
112-
this.getTableColumnName(runParameters),
113112
this.getTableColumnName(runParameters),
114113
runParameters.getConnection().getBigquery().getSourceProjectId(),
115114
runParameters.getTable().getPhysicalTableName().getSchemaName(),
@@ -133,8 +132,8 @@ void renderSensor_whenProfilingOneTimeSeriesNoDataStream_thenRendersCorrectSql()
133132
SELECT
134133
SUM(
135134
CASE
136-
WHEN %s < 0 OR %s IS NULL THEN 0
137-
ELSE 1
135+
WHEN %s >= 0 THEN 1
136+
ELSE 0
138137
END
139138
) AS actual_value,
140139
analyzed_table.`date` AS time_period,
@@ -145,7 +144,6 @@ void renderSensor_whenProfilingOneTimeSeriesNoDataStream_thenRendersCorrectSql()
145144
ORDER BY time_period, time_period_utc""";
146145

147146
Assertions.assertEquals(String.format(target_query,
148-
this.getTableColumnName(runParameters),
149147
this.getTableColumnName(runParameters),
150148
runParameters.getConnection().getBigquery().getSourceProjectId(),
151149
runParameters.getTable().getPhysicalTableName().getSchemaName(),
@@ -163,15 +161,14 @@ void renderSensor_whenMonitoringDefaultTimeSeriesNoDataStream_thenRendersCorrect
163161
SELECT
164162
SUM(
165163
CASE
166-
WHEN %s < 0 OR %s IS NULL THEN 0
167-
ELSE 1
164+
WHEN %s >= 0 THEN 1
165+
ELSE 0
168166
END
169167
) AS actual_value
170168
FROM `%s`.`%s`.`%s` AS analyzed_table
171169
WHERE (%s)""";
172170

173171
Assertions.assertEquals(String.format(target_query,
174-
this.getTableColumnName(runParameters),
175172
this.getTableColumnName(runParameters),
176173
runParameters.getConnection().getBigquery().getSourceProjectId(),
177174
runParameters.getTable().getPhysicalTableName().getSchemaName(),
@@ -189,8 +186,8 @@ void renderSensor_whenPartitionedDefaultTimeSeriesNoDataStream_thenRendersCorrec
189186
SELECT
190187
SUM(
191188
CASE
192-
WHEN %s < 0 OR %s IS NULL THEN 0
193-
ELSE 1
189+
WHEN %s >= 0 THEN 1
190+
ELSE 0
194191
END
195192
) AS actual_value,
196193
analyzed_table.`date` AS time_period,
@@ -203,7 +200,6 @@ void renderSensor_whenPartitionedDefaultTimeSeriesNoDataStream_thenRendersCorrec
203200
ORDER BY time_period, time_period_utc""";
204201

205202
Assertions.assertEquals(String.format(target_query,
206-
this.getTableColumnName(runParameters),
207203
this.getTableColumnName(runParameters),
208204
runParameters.getConnection().getBigquery().getSourceProjectId(),
209205
runParameters.getTable().getPhysicalTableName().getSchemaName(),
@@ -226,8 +222,8 @@ void renderSensor_whenProfilingNoTimeSeriesOneDataStream_thenRendersCorrectSql()
226222
SELECT
227223
SUM(
228224
CASE
229-
WHEN %s < 0 OR %s IS NULL THEN 0
230-
ELSE 1
225+
WHEN %s >= 0 THEN 1
226+
ELSE 0
231227
END
232228
) AS actual_value,
233229
analyzed_table.`length_string` AS grouping_level_1
@@ -237,7 +233,6 @@ void renderSensor_whenProfilingNoTimeSeriesOneDataStream_thenRendersCorrectSql()
237233
ORDER BY grouping_level_1""";
238234

239235
Assertions.assertEquals(String.format(target_query,
240-
this.getTableColumnName(runParameters),
241236
this.getTableColumnName(runParameters),
242237
runParameters.getConnection().getBigquery().getSourceProjectId(),
243238
runParameters.getTable().getPhysicalTableName().getSchemaName(),
@@ -258,8 +253,8 @@ void renderSensor_whenMonitoringDefaultTimeSeriesOneDataStream_thenRendersCorrec
258253
SELECT
259254
SUM(
260255
CASE
261-
WHEN %s < 0 OR %s IS NULL THEN 0
262-
ELSE 1
256+
WHEN %s >= 0 THEN 1
257+
ELSE 0
263258
END
264259
) AS actual_value,
265260
analyzed_table.`length_string` AS grouping_level_1
@@ -269,7 +264,6 @@ void renderSensor_whenMonitoringDefaultTimeSeriesOneDataStream_thenRendersCorrec
269264
ORDER BY grouping_level_1""";
270265

271266
Assertions.assertEquals(String.format(target_query,
272-
this.getTableColumnName(runParameters),
273267
this.getTableColumnName(runParameters),
274268
runParameters.getConnection().getBigquery().getSourceProjectId(),
275269
runParameters.getTable().getPhysicalTableName().getSchemaName(),
@@ -290,8 +284,8 @@ void renderSensor_whenPartitionedDefaultTimeSeriesOneDataStream_thenRendersCorre
290284
SELECT
291285
SUM(
292286
CASE
293-
WHEN %s < 0 OR %s IS NULL THEN 0
294-
ELSE 1
287+
WHEN %s >= 0 THEN 1
288+
ELSE 0
295289
END
296290
) AS actual_value,
297291
analyzed_table.`length_string` AS grouping_level_1,
@@ -305,7 +299,6 @@ void renderSensor_whenPartitionedDefaultTimeSeriesOneDataStream_thenRendersCorre
305299
ORDER BY grouping_level_1, time_period, time_period_utc""";
306300

307301
Assertions.assertEquals(String.format(target_query,
308-
this.getTableColumnName(runParameters),
309302
this.getTableColumnName(runParameters),
310303
runParameters.getConnection().getBigquery().getSourceProjectId(),
311304
runParameters.getTable().getPhysicalTableName().getSchemaName(),
@@ -334,8 +327,8 @@ void renderSensor_whenProfilingOneTimeSeriesThreeDataStream_thenRendersCorrectSq
334327
SELECT
335328
SUM(
336329
CASE
337-
WHEN %s < 0 OR %s IS NULL THEN 0
338-
ELSE 1
330+
WHEN %s >= 0 THEN 1
331+
ELSE 0
339332
END
340333
) AS actual_value,
341334
analyzed_table.`strings_with_numbers` AS grouping_level_1,
@@ -349,7 +342,6 @@ void renderSensor_whenProfilingOneTimeSeriesThreeDataStream_thenRendersCorrectSq
349342
ORDER BY grouping_level_1, grouping_level_2, grouping_level_3, time_period, time_period_utc""";
350343

351344
Assertions.assertEquals(String.format(target_query,
352-
this.getTableColumnName(runParameters),
353345
this.getTableColumnName(runParameters),
354346
runParameters.getConnection().getBigquery().getSourceProjectId(),
355347
runParameters.getTable().getPhysicalTableName().getSchemaName(),
@@ -372,8 +364,8 @@ void renderSensor_whenMonitoringDefaultTimeSeriesThreeDataStream_thenRendersCorr
372364
SELECT
373365
SUM(
374366
CASE
375-
WHEN %s < 0 OR %s IS NULL THEN 0
376-
ELSE 1
367+
WHEN %s >= 0 THEN 1
368+
ELSE 0
377369
END
378370
) AS actual_value,
379371
analyzed_table.`strings_with_numbers` AS grouping_level_1,
@@ -385,7 +377,6 @@ void renderSensor_whenMonitoringDefaultTimeSeriesThreeDataStream_thenRendersCorr
385377
ORDER BY grouping_level_1, grouping_level_2, grouping_level_3""";
386378

387379
Assertions.assertEquals(String.format(target_query,
388-
this.getTableColumnName(runParameters),
389380
this.getTableColumnName(runParameters),
390381
runParameters.getConnection().getBigquery().getSourceProjectId(),
391382
runParameters.getTable().getPhysicalTableName().getSchemaName(),
@@ -408,8 +399,8 @@ void renderSensor_whenPartitionedDefaultTimeSeriesThreeDataStream_thenRendersCor
408399
SELECT
409400
SUM(
410401
CASE
411-
WHEN %s < 0 OR %s IS NULL THEN 0
412-
ELSE 1
402+
WHEN %s >= 0 THEN 1
403+
ELSE 0
413404
END
414405
) AS actual_value,
415406
analyzed_table.`strings_with_numbers` AS grouping_level_1,
@@ -425,7 +416,6 @@ void renderSensor_whenPartitionedDefaultTimeSeriesThreeDataStream_thenRendersCor
425416
ORDER BY grouping_level_1, grouping_level_2, grouping_level_3, time_period, time_period_utc""";
426417

427418
Assertions.assertEquals(String.format(target_query,
428-
this.getTableColumnName(runParameters),
429419
this.getTableColumnName(runParameters),
430420
runParameters.getConnection().getBigquery().getSourceProjectId(),
431421
runParameters.getTable().getPhysicalTableName().getSchemaName(),

‎dqops/src/test/java/com/dqops/sensors/bigquery/column/numeric/ColumnNumericNonNegativePercentSensorParametersSpecBigQueryTests.java

+20-20
Original file line numberDiff line numberDiff line change
@@ -103,8 +103,8 @@ void renderSensor_whenProfilingNoTimeSeriesNoDataStream_thenRendersCorrectSql()
103103
WHEN COUNT(%1$s) = 0 THEN 0.0
104104
ELSE 100.0 * SUM(
105105
CASE
106-
WHEN %1$s < 0 THEN 0
107-
ELSE 1
106+
WHEN %1$s >= 0 THEN 1
107+
ELSE 0
108108
END
109109
) / COUNT(%1$s)
110110
END AS actual_value
@@ -137,8 +137,8 @@ void renderSensor_whenProfilingOneTimeSeriesNoDataStream_thenRendersCorrectSql()
137137
WHEN COUNT(%1$s) = 0 THEN 0.0
138138
ELSE 100.0 * SUM(
139139
CASE
140-
WHEN %1$s < 0 THEN 0
141-
ELSE 1
140+
WHEN %1$s >= 0 THEN 1
141+
ELSE 0
142142
END
143143
) / COUNT(%1$s)
144144
END AS actual_value,
@@ -169,8 +169,8 @@ void renderSensor_whenMonitoringDefaultTimeSeriesNoDataStream_thenRendersCorrect
169169
WHEN COUNT(%1$s) = 0 THEN 0.0
170170
ELSE 100.0 * SUM(
171171
CASE
172-
WHEN %1$s < 0 THEN 0
173-
ELSE 1
172+
WHEN %1$s >= 0 THEN 1
173+
ELSE 0
174174
END
175175
) / COUNT(%1$s)
176176
END AS actual_value
@@ -197,8 +197,8 @@ void renderSensor_whenPartitionedDefaultTimeSeriesNoDataStream_thenRendersCorrec
197197
WHEN COUNT(%1$s) = 0 THEN 0.0
198198
ELSE 100.0 * SUM(
199199
CASE
200-
WHEN %1$s < 0 THEN 0
201-
ELSE 1
200+
WHEN %1$s >= 0 THEN 1
201+
ELSE 0
202202
END
203203
) / COUNT(%1$s)
204204
END AS actual_value,
@@ -236,8 +236,8 @@ void renderSensor_whenProfilingNoTimeSeriesOneDataStream_thenRendersCorrectSql()
236236
WHEN COUNT(%1$s) = 0 THEN 0.0
237237
ELSE 100.0 * SUM(
238238
CASE
239-
WHEN %1$s < 0 THEN 0
240-
ELSE 1
239+
WHEN %1$s >= 0 THEN 1
240+
ELSE 0
241241
END
242242
) / COUNT(%1$s)
243243
END AS actual_value,
@@ -270,8 +270,8 @@ void renderSensor_whenMonitoringDefaultTimeSeriesOneDataStream_thenRendersCorrec
270270
WHEN COUNT(%1$s) = 0 THEN 0.0
271271
ELSE 100.0 * SUM(
272272
CASE
273-
WHEN %1$s < 0 THEN 0
274-
ELSE 1
273+
WHEN %1$s >= 0 THEN 1
274+
ELSE 0
275275
END
276276
) / COUNT(%1$s)
277277
END AS actual_value,
@@ -304,8 +304,8 @@ void renderSensor_whenPartitionedDefaultTimeSeriesOneDataStream_thenRendersCorre
304304
WHEN COUNT(%1$s) = 0 THEN 0.0
305305
ELSE 100.0 * SUM(
306306
CASE
307-
WHEN %1$s < 0 THEN 0
308-
ELSE 1
307+
WHEN %1$s >= 0 THEN 1
308+
ELSE 0
309309
END
310310
) / COUNT(%1$s)
311311
END AS actual_value,
@@ -350,8 +350,8 @@ void renderSensor_whenProfilingOneTimeSeriesThreeDataStream_thenRendersCorrectSq
350350
WHEN COUNT(%1$s) = 0 THEN 0.0
351351
ELSE 100.0 * SUM(
352352
CASE
353-
WHEN %1$s < 0 THEN 0
354-
ELSE 1
353+
WHEN %1$s >= 0 THEN 1
354+
ELSE 0
355355
END
356356
) / COUNT(%1$s)
357357
END AS actual_value,
@@ -390,8 +390,8 @@ void renderSensor_whenMonitoringDefaultTimeSeriesThreeDataStream_thenRendersCorr
390390
WHEN COUNT(%1$s) = 0 THEN 0.0
391391
ELSE 100.0 * SUM(
392392
CASE
393-
WHEN %1$s < 0 THEN 0
394-
ELSE 1
393+
WHEN %1$s >= 0 THEN 1
394+
ELSE 0
395395
END
396396
) / COUNT(%1$s)
397397
END AS actual_value,
@@ -428,8 +428,8 @@ void renderSensor_whenPartitionedDefaultTimeSeriesThreeDataStream_thenRendersCor
428428
WHEN COUNT(%1$s) = 0 THEN 0.0
429429
ELSE 100.0 * SUM(
430430
CASE
431-
WHEN %1$s < 0 THEN 0
432-
ELSE 1
431+
WHEN %1$s >= 0 THEN 1
432+
ELSE 0
433433
END
434434
) / COUNT(%1$s)
435435
END AS actual_value,

0 commit comments

Comments
 (0)