Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing .get(col_name) #2104

Closed
gbrault opened this issue Aug 16, 2023 · 1 comment · Fixed by #2134
Closed

missing .get(col_name) #2104

gbrault opened this issue Aug 16, 2023 · 1 comment · Fixed by #2134
Labels
bug

Comments

@gbrault
Copy link

gbrault commented Aug 16, 2023

Flask-AppBuilder/flask_appbuilder/views.py

Line 463 in 6130d07

def api_column_edit(self, col_name):

@dpgaspar as you can see, in the add, you have the .get(col_name) in

        if self.add_form_query_rel_fields:
            filter_rel_fields = self.add_form_query_rel_fields.get(col_name)

But it's missing in the edit!

Adding it just fix the issue!
@dpgaspar dpgaspar mentioned this issue Oct 13, 2023
Merged
6 tasks
@dpgaspar
Copy link
Owner

@gbrault thank you

Made the fix, but, please make sure to not depend on this API, it's deprecated

@dpgaspar dpgaspar added the bug label Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: old API api column edit dpgaspar/Flask-AppBuilder
2 participants
@dpgaspar @gbrault