Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SD-170] Single line primary nav #1286

Closed
wants to merge 6 commits into from

Conversation

waitingallday
Copy link
Member

@waitingallday waitingallday commented Aug 12, 2024

Issue: https://digital-vic.atlassian.net/browse/SD-170

What I did

  • Added the feature flag primaryNavNowrap, to selectively add a class for preventing long primary nav link titles from wrapping to multiple lines.

How to test

  • Cypress

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@waitingallday waitingallday added this to the v2.14.0 milestone Aug 12, 2024
@waitingallday waitingallday changed the base branch from develop to release/2.14.0 August 12, 2024 07:38
Copy link

netlify bot commented Aug 12, 2024

Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 42f8fe3
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/66b9bbd823df0c0008036f4c

Copy link

cypress bot commented Aug 12, 2024



Test summary

188 0 0 0


Run details

Project ripple-framework
Status Passed
Commit 42f8fe3
Started Aug 12, 2024 7:37 AM
Ended Aug 12, 2024 7:47 AM
Duration 09:12 💡
OS Linux Ubuntu -
Browser Electron 118

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@jeffdowdle
Copy link
Contributor

I think it would work best to merge develop in after a patch release in a different PR, just makes this PR hard to read

@waitingallday
Copy link
Member Author

Oh yeah, this was branched off develop and I changed the base 😕 Let me fix that

@waitingallday waitingallday removed this from the v2.14.0 milestone Aug 12, 2024
@waitingallday
Copy link
Member Author

Closed in favour of #1287 (branched from wrong base)

@waitingallday waitingallday deleted the feat/SD-170-single-line-nav branch August 12, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants